Last 0.2.8 commit

Author: rweigel

hapiclient/log.py

@@ -5,6 +5,16 @@
 _INTERNAL_HANDLER_ATTR = "_hapiclient_internal_handler"
 _INTERNAL_LEVEL_ATTR = "_hapiclient_internal_level"
 
+# Disable propagation and add NullHandler by default so hapiclient
+# is silent unless explicitly configured by user. This is the standard
+# practice for library loggers.
+_logger.propagate = False
+_logger.setLevel(_logging.NOTSET)
+if not _logger.handlers:
+    _null_handler = _logging.NullHandler()
+    setattr(_null_handler, _INTERNAL_HANDLER_ATTR, True)
+    _logger.addHandler(_null_handler)
+
 
 def configure_logging(opts):
     """Configure the hapiclient logger based on opts['logging'].
@@ -31,13 +41,11 @@ def configure_logging(opts):
             _logger.addHandler(_handler)
     else:
         if has_user_level or has_user_handlers:
-            if has_user_handlers:
-                log("Ignoring logging=%s because standard Python logger for 'hapiclient' already configured with handlers." % opts['logging'])
-            else:
-                log("Ignoring logging=%s because standard Python logger for 'hapiclient' already configured with log_level != NOTSET." % opts['logging'])
+            # Don't log when logging is disabled - would cause output during tests
+            pass
         else:
-            _logger.setLevel(_logging.WARNING)
-            setattr(_logger, _INTERNAL_LEVEL_ATTR, _logging.WARNING)
+            _logger.setLevel(_logging.NOTSET)
+            setattr(_logger, _INTERNAL_LEVEL_ATTR, _logging.NOTSET)
 
 
 def log(msg, opts=None):

test/test_chunking.py

@@ -11,7 +11,7 @@
 
 logger = get_logger(__name__)
 
-hapi_logging = True
+hapi_logging = False
 if logging.getLevelName(logger.level) == 'DEBUG':
     hapi_logging = True