Skip to content

Commit 5ba7f78

Browse files
committed
Cross-browser file naming consistency, in spite of version numbering incompatibilities.
1 parent 2c08b0a commit 5ba7f78

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

build.sh

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ strip_rc_ver() {
1515
if [[ "$2" == "rel" ]]; then
1616
replace='s/("version":.*)rc\d+/$1/'
1717
else
18-
replace='s/("version":.*)(\d+)rc(\d+)/{$1 . ($2 == "0" ? "0" : ($2-1) . ".9" . sprintf("%03d", $3))}/e'
18+
replace='s/("version":.*?)(\d+)rc(\d+)/{$1 . ($2 == "0" ? "0" : ($2-1) . ".9" . sprintf("%03d", $3))}/e'
1919
fi
2020
perl -pi.bak -e "$replace" "$MANIFEST" && rm -f "$MANIFEST".bak
2121
}
@@ -110,11 +110,14 @@ if ! grep '"id":' "$MANIFEST_OUT" >/dev/null; then
110110
fi
111111

112112
if [ "$1" != "debug" ]; then
113+
DBG=""
113114
for file in "$SRC"/content/*.js; do
114115
if grep -P '\/\/\s(REL|DEV)_ONLY' "$file" >/dev/null; then
115116
sed -re 's/\s*\/\/\s*(\S.*)\s*\/\/\s*REL_ONLY.*/\1/' -e 's/.*\/\/\s*DEV_ONLY.*//' "$file" > "$BUILD/content/$(basename "$file")"
116117
fi
117118
done
119+
else
120+
DBG="-dbg"
118121
fi
119122

120123
echo "Creating $XPI.xpi..."
@@ -145,11 +148,11 @@ elif [ -f "$XPI.zip" ]; then
145148
echo "A signed $XPI.xpi already exists, not overwriting."
146149
else
147150
[[ "$VER" == *rc* ]] && xpicmd="mv" || xpicmd="cp"
148-
$xpicmd "$XPI.zip" "$XPI.xpi"
149-
echo "Created $XPI.xpi"
151+
$xpicmd "$XPI.zip" "$XPI$DBG.xpi"
152+
echo "Created $XPI$DBG.xpi"
150153
fi
151154
else
152-
echo >&2 "ERROR: Could not create $XPI.xpi!"
155+
echo >&2 "ERROR: Could not create $XPI$DBG.xpi!"
153156
exit 3
154157
fi
155158
ln -fs $XPI.xpi "$BASE/latest.xpi"
@@ -181,14 +184,15 @@ fi
181184
"$MANIFEST_OUT".tmp && \
182185
mv "$MANIFEST_OUT.tmp" "$MANIFEST_OUT"
183186

184-
build
187+
CHROME_ZIP=$(build | grep 'ready: .*\.zip' | sed -re 's/.* ready: //')
185188

186-
if [ -f "$XPI.zip" ]; then
187-
mv "$XPI.zip" "$XPI-edge.zip"
189+
if [ -f "$CHROME_ZIP" ]; then
190+
mv "$CHROME_ZIP" "$XPI$DBG-edge.zip"
188191
# remove Edge-specific manifest lines and package for generic Chromium
189192
grep -v '"update_url":' "$MANIFEST_OUT" > "$MANIFEST_OUT.tmp" && \
190193
mv "$MANIFEST_OUT.tmp" "$MANIFEST_OUT" && \
191194
build
195+
mv "$CHROME_ZIP" "$XPI$DBG-chrome.zip"
192196
fi
193197

194198
mv "$BUILD" "$CHROMIUM_UNPACKED"

0 commit comments

Comments
 (0)