Commit 05d42ec
Tighten rtol/atol from 1e-2 to 1e-3 for Helion kernels (#132)
All four Helion kernels (causal_conv1d, gated_deltanet_chunk_fwd_h,
chunk_fwd_o, recompute_w_u) operate in float32 but used overly loose
tolerances of rtol=1e-2, atol=1e-2. Tighten to 1e-3 to better catch
numerical bugs while still allowing for accumulation chain error.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent ec71b91 commit 05d42ec
4 files changed
Lines changed: 6 additions & 6 deletions
File tree
- problems/helion
- causal_conv1d_py
- gated_deltanet_chunk_fwd_h_py
- gated_deltanet_chunk_fwd_o_py
- gated_deltanet_recompute_w_u_py
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
100 | | - | |
| 99 | + | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
76 | | - | |
| 75 | + | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
0 commit comments