Fixed geolography test failing issue

Author: kiraksi

sqlalchemy_bigquery/base.py

@@ -972,8 +972,19 @@ def _get_table(self, connection, table_name, schema=None):
         return table
 
     def has_table(self, connection, table_name, schema=None, **kw):
-        """
-        No kw are supported
+        """Checks whether a table exists in BigQuery.
+
+        Args:
+            connection (google.cloud.bigquery.client.Client): The client
+                object used to interact with BigQuery.
+            table_name (str): The name of the table to check for.
+            schema (str, optional): The name of the schema to which the table
+                belongs. Defaults to the default schema.
+            **kw (dict): Any extra keyword arguments will be ignored.
+
+        Returns:
+            bool: True if the table exists, False otherwise.
+
         """
         try:
             self._get_table(connection, table_name, schema)

tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py

@@ -41,24 +41,21 @@
     QuotedNameArgumentTest,
     SimpleUpdateDeleteTest as _SimpleUpdateDeleteTest,
     TimestampMicrosecondsTest as _TimestampMicrosecondsTest,
-    TrueDivTest as _TrueDivTest,
-    IntegerTest as _IntegerTest,
-    NumericTest as _NumericTest,
-    DifficultParametersTest as _DifficultParametersTest,
-    FetchLimitOffsetTest as _FetchLimitOffsetTest,
 )
 
 if packaging.version.parse(sqlalchemy.__version__) >= packaging.version.parse("2.0"):
     from sqlalchemy.sql import type_coerce
+    from sqlalchemy.testing.suite import (
+        TrueDivTest as _TrueDivTest,
+        IntegerTest as _IntegerTest,
+        NumericTest as _NumericTest,
+        DifficultParametersTest as _DifficultParametersTest,
+        FetchLimitOffsetTest as _FetchLimitOffsetTest,
+    )
 
     class TimestampMicrosecondsTest(_TimestampMicrosecondsTest):
         data = datetime.datetime(2012, 10, 15, 12, 57, 18, 396, tzinfo=pytz.UTC)
 
-        # TimestampMicrosecondsTest literal() no literal_execute parameter? Go back and add to literal()"
-        @pytest.mark.skip("")
-        def test_literal(self, literal_round_trip):
-            pass
-
         def test_select_direct(self, connection):
             # This func added because this test was failing when passed the
             # UTC timezone.
@@ -93,14 +90,12 @@ def test_round_trip_executemany(self, connection):
         test_round_trip_executemany
     )
 
-    # TrueDivTest issue because SQLAlchemy always rounded down. The assertion cannot reconcile 1.5==1 thusly
     class TrueDivTest(_TrueDivTest):
-        @pytest.mark.skip("Bigquery rounds based on datatype")
+        @pytest.mark.skip("BQ rounds based on datatype")
         def test_floordiv_integer(self):
-            # TODO: possibly compare rounded result instead?
             pass
 
-        @pytest.mark.skip("Bigquery rounds based on datatype")
+        @pytest.mark.skip("BQ rounds based on datatype")
         def test_floordiv_integer_bound(self):
             pass
 
@@ -138,7 +133,6 @@ class InsertBehaviorTest(_InsertBehaviorTest):
         def test_insert_from_select_autoinc(cls):
             pass
 
-        # TODO: Find cause of error
         @pytest.mark.skip(
             "BQ has no autoinc and client-side defaults can't work for select."
         )
@@ -167,7 +161,7 @@ def run(type_, input_, output, filter_=None, check_scale=False):
 
                 where_expr = True
 
-                # Adding where clause
+                # Adding where clause for 2.0 compatibility
                 connection.execute(t.delete().where(where_expr))
 
                 # test that this is actually a number!

tests/system/test_geography.py

@@ -128,7 +128,9 @@ def test_geoalchemy2_core(bigquery_dataset):
         int(
             list(
                 conn.execute(
-                    select(lake_table.c.geog.st_area(), lake_table.c.name == "test2")
+                    select(lake_table.c.geog.st_area()).where(
+                        lake_table.c.name == "test2"
+                    )
                 )
             )[0][0]
         )