feat(internal/librarian): make formatLibrary a no-op for Python (#3731)

jskeet · web-flow · commit b6aa3fb25d01 · 2026-01-26T16:41:13.000Z
Generation already includes formatting, so formatLibrary should currently just skip (rather than fail) when its input is a Python library. Related to #3730
diff --git a/internal/librarian/generate.go b/internal/librarian/generate.go
@@ -285,6 +285,11 @@ func formatLibrary(ctx context.Context, language string, library *config.Library
 		return dart.Format(ctx, library)
 	case languageRust:
 		return rust.Format(ctx, library)
+	case languagePython:
+		// Python formatting is currently performed in the generate phase.
+		// TODO(https://github.com/googleapis/librarian/issues/3730): separate
+		// generation and formatting for Python.
+		return nil
 	}
 	return fmt.Errorf("language %q does not support formatting", language)
 }

Original file line number	Diff line number	Diff line change
`@@ -285,6 +285,11 @@ func formatLibrary(ctx context.Context, language string, library *config.Library`
`285`	`285`	`return dart.Format(ctx, library)`
`286`	`286`	`case languageRust:`
`287`	`287`	`return rust.Format(ctx, library)`
	`288`	`+ case languagePython:`
	`289`	`+ // Python formatting is currently performed in the generate phase.`
	`290`	`+ // TODO(https://github.com/googleapis/librarian/issues/3730): separate`
	`291`	`+ // generation and formatting for Python.`
	`292`	`+ return nil`
`288`	`293`	`}`
`289`	`294`	`return fmt.Errorf("language %q does not support formatting", language)`
`290`	`295`	`}`