remove feature filter

Author: juliendidier

src/Gitonomy/ChangeLog/Filter/FeatureFilter.php

@@ -10,16 +10,9 @@ static function createFromRequest(Request $request)
     {
         $parameters = $request->query;
 
-        $version       = $parameters->get('from_version', 0.0);
-        $versionFilter = new VersionFilter($version);
+        $version = $parameters->get('from_version', 0.0);
+        $filter  = new VersionFilter($version);
 
-        if ($parameters->has('levels')) {
-            $levels        = explode(',', $parameters->get('levels'));
-            $featureFilter = new FeatureFilter($levels);
-
-            $versionFilter->setFeatureFilter($featureFilter);
-        }
-
-        return new ChangeLogFilter($versionFilter);
+        return new ChangeLogFilter($filter);
     }
 }

src/Gitonomy/ChangeLog/Filter/FilterFactory.php

@@ -6,19 +6,13 @@
 
 class VersionFilter
 {
-    protected $featureFilter;
     protected $minimumVersion;
 
     public function __construct($minimumVersion)
     {
         $this->minimumVersion = $minimumVersion;
     }
 
-    public function setFeatureFilter(FeatureFilter $featureFilter)
-    {
-        $this->featureFilter = $featureFilter;
-    }
-
     public function filter(Version $version)
     {
         if (!$this->isTrue($version)) {
@@ -28,11 +22,7 @@ public function filter(Version $version)
         $result = new Version($version->getVersion(), $version->getDate());
 
         foreach ($version->getFeatures() as $feature) {
-            if (null === $this->featureFilter) {
-                $result->addFeature($feature);
-            } elseif (null !== $filter = $this->featureFilter->filter($feature)) {
-                $result->addFeature($filter);
-            }
+            $result->addFeature($feature);
         }
 
         return $result;

src/Gitonomy/ChangeLog/Filter/VersionFilter.php

@@ -5,7 +5,7 @@
 use Buzz\Browser;
 use Buzz\Client\Curl;
 
-use Gitonomy\ChangeLog\Parser\Parser;
+use Gitonomy\ChangeLog\Parser\ChangeLogParser;
 
 class GithubLoader implements LoaderInterface
 {
@@ -22,7 +22,7 @@ public function load()
         }
 
         $content = $response->getContent();
-        $parser  = new Parser();
+        $parser  = new ChangeLogParser();
 
         return $parser->parse($content);
     }

src/Gitonomy/ChangeLog/Loader/GithubLoader.php

@@ -16,53 +16,13 @@
 use Gitonomy\ChangeLog\Node\Version;
 use Gitonomy\ChangeLog\Node\Feature;
 
-class Parser
+abstract class Parser
 {
     protected $cursor;
     protected $content;
     protected $length;
 
-    public function parse($content)
-    {
-        $this->cursor  = 0;
-        $this->content = $content;
-        $this->length  = strlen($this->content);
-
-        $changeLog = new ChangeLog();
-
-        while (!$this->isFinished()) {
-
-            if ($this->expects('* ')) {
-                $version = $this->consumeTo("\n");
-
-                preg_match('#v(?P<version>[^/]+) \((?P<date>[0-9]{4}-[0-9]{2}-[0-9]{2})\)#', $version, $versionData);
-
-                if (array() === $versionData) {
-                    $version = new Version($version);
-                } else {
-                    $version = new Version($versionData['version'], $versionData['date']);
-                }
-
-                $changeLog->addVersion($version);
-            }
-
-            if ($this->expects('  * ')) {
-                $feature = $this->consumeTo("\n");
-
-                preg_match('#(?P<level>\w+) (?P<feature>[^.]+)#', $feature, $featureData);
-
-                if (null === $version) {
-                    continue;
-                }
-
-                $version->addFeature(new Feature($featureData['level'], $featureData['feature']));
-            }
-
-            $this->consumeNewLine();
-        }
-
-        return $changeLog;
-    }
+    abstract function parse($content);
 
     public function isFinished()
     {