use better filler responses

hectorsector · hectorsector · commit 03268eb23ff5 · 2019-04-08T19:24:08.000-04:00
diff --git a/config.yml b/config.yml
@@ -75,7 +75,7 @@ steps:
 #6
 - title: Answer the templates challenge question
   description: Answer the templates challenge question
-  event: issue_comment.created
+  event: pull_request.edited
   actions:
   - type: respond
     with: templates-answer.md
@@ -98,7 +98,7 @@ steps:
 #8
 - title: Answer the workflows challenge question
   description: Answer the workflows challenge question
-  event: issue_comment.created
+  event: pull_request.edited
   actions:
   - type: respond
     with: workflows-answer.md
@@ -121,7 +121,7 @@ steps:
 #10 
 - title: Answer the project management challenge
   description: Answer the project management challenge
-  event: issue_comment.created
+  event: pull_request.edited
   actions:
   - type: respond
     with: projects-answer.md
diff --git a/responses/congratulations.md b/responses/congratulations.md
@@ -1,3 +1,8 @@
-13: on pr.closed (learner merged)
-    - bot opens final issue, explaining what to do with this repo, includes instructions about forking or cloning
-    - bot congratulates learner on completion, recommends next steps
+# :tada: Congratulations
+
+You are finished with this course. You can see a deployed version of our work together at [LINK]. Feel free to share this link directly with others, or move it to your own organization.
+
+- If your organization is on GitHub.com, [fork it]().
+- If your organization is on GitHub Enterprise Server, [clone and push it]() to your instance. 
+
+Your next steps are in the [Innersource learning path]().
diff --git a/responses/discoverability-answer.md b/responses/discoverability-answer.md
@@ -1,6 +1,12 @@
-4: on issue_comment.created (learner answered)
-- bot validates response
-- bot explains topics, name, description, url
-- asks learner to merge
+### Answer :crystal_ball:
+
+This repository is actually for ___.
+
+Did you guess it? Probably not, because it doesn't contain many of the necessary elements to make a repository discoverable.
+
+Some suggestions to ensure your teammates can find your repository are:
+- use a descriptive repository name
+- give your repository a description
+- provide a URL for the deployment of the app, or documentation about this project
 
 Please merge this PR.
diff --git a/responses/discoverable.md b/responses/discoverable.md
@@ -1,4 +1,9 @@
-3: on pr.closed (learner merged)
-- bot opens PR for creating discoverable repos
-- challenge question: what is this repository for? screenshot of a repo with no README, topics, etc
-- learner enters response, likely will fail
+This PR is all about how to make your repositories more discoverable.
+
+### Challenge question
+
+What is this repository for?
+
+[SCREENSHOT OF BARE REPOSITORY WITHOUT DOCS]
+
+I'll respond when I detect you've submitted a comment on this PR.
diff --git a/responses/metrics-answer.md b/responses/metrics-answer.md
@@ -1,4 +1,8 @@
-12: on issue_comment.edited (learner voted)
-    - bot validates, most of the checked answers are probably right
-    - bot references PR docs, talks about measuring strategies
-    - asks learner to merge
+### Answer :crystal_ball:
+
+Those are great ideas!
+
+Here are some other ideas of measuring how well you're doing:
+- IDEAS HERE
+
+I'll respond when you merge this PR. 
diff --git a/responses/metrics.md b/responses/metrics.md
@@ -1,4 +1,7 @@
-11: on pr.closed (learner merge)
-    - bot creates PR about measuring success
-    - challenge question: what might be some ways to measure success? 
-    - learner votes
+Once you've implemented Innersource strategies, how do you know it's working? 
+
+### Challenge question
+
+What might be some ways to measure the success of Innersource strategies?
+
+I'll respond when you submit a comment to this PR. 
diff --git a/responses/projects-answer.md b/responses/projects-answer.md
@@ -1,4 +1,7 @@
-10: on issue_comment.edited (learner voted)
-    - bot explains that since no project management is involved, any answer is fair game
-    - bot explains docs in PR, lightweight project management on GitHub, explicitly calling out project management strategies
-    - asks learner to merge
+### Answer :crystal_ball:
+
+Without a clear project management strategy, you might as well pick any issue.
+
+Being explicit about your project management tool, whether it's inside of GitHub or elsewhere, will help potential contributors figure out whether their contribution will be immediately beneficial or triaged. 
+
+I'll respond when you merge this PR. 
diff --git a/responses/projects.md b/responses/projects.md
@@ -1,4 +1,14 @@
-9: on pr.closed (learner merged)
-- bot creates PR about Project management
-- challenge: what should you work on? screenshot of issues
-- learner chooses one
+This to discuss project management!
+
+### Challenge question
+
+Here's some open issues in this company project. Which one should you work on?
+
+[SCREENSHOT OF A HANDFUL OF ISSUES]
+
+- [ ] issue 1
+- [ ] issue 2
+- [ ] issue 3
+- [ ] issue 4
+
+I'll respond when you check one of the boxes above. 
diff --git a/responses/repo-owner-answer.md b/responses/repo-owner-answer.md
@@ -1,10 +1,15 @@
-- answer: true, it _does_ exist, but it is a repository private to the github organization, so it's not visible, this is because of org permissions. Private repositories in the org are only visible by members of that org
-
-2: on issue_comment.edited (learner voted)
-- bot validates guess, drops explanations
-- response explains ownership of repositories, name of repositories
-- response recommends few orgs as possible
-- response explains team mentions across orgs
-- bot asks learner to merge the PR
+### Answer :crystal_ball:
+
+A repository _does_ exist at githubtraining/training-manual.
+
+<details>
+<summary>Why can't you see it then? Review the **Files Changed** tab and see if you can figure it out. Collapse this text if you'd like an explanation.</summary>
+
+The repository `training-manual` in the @githubtraining organization is private, and only visible to memebers of that organization. If you're not a member of the organization, it'll appear like the repository doesn't exist to you. This is an example of why having the right ownership structure is important. Having too many organizations with restrictive permissions means that each organization's work will be siloed. 
+</summary>
+
+Here are some recommendations based on some :sparkles: use of GitHub that we've seen:
+- aim for as few organizations as possible, remember: each organization is a black box to those outside of that organization
+- name your repositories in a meaningful manner, usually a simple project or application name will suffice
 
 Please merge this PR.
diff --git a/responses/repo-owner.md b/responses/repo-owner.md
@@ -1,5 +1,10 @@
-- Open PR for repo ownership
-- response contains challenge question: true/false there is a repository at https://github.com/githubtraining/training-manual
+This pull request is all about repository ownership and naming conventions. 
 
-- [ ] True, there is a repository at githubtraining/training-manual
-- [ ] False, no repository exists at githubtraining/training-manual
+### Challenge question
+
+Does a repository exist at https://github.com/githubtraining/training-manual?
+
+- [ ] True, there is at the given URL.
+- [ ] False, no repository exists at the given URL.
+
+I'll respond when I detect you've checked one of the boxes above. 
diff --git a/responses/templates-answer.md b/responses/templates-answer.md
@@ -1,4 +1,7 @@
-6: on issue_comment.edited (learner voted)
-- bot responds why there's no right answer
-- bot talks about issue and PR templates examples
-- asks learner to merge
+### Answer :crystal_ball:
+
+Every project _can_ have a different way to submit bug reports, so all the answers are right. 
+
+But, how could you know? With issue and pull request templates, you can take the mystery out of the equation and allow anyone across the organization to know the way each project prefers to receive issues and contributions.
+
+Please merge this PR.
diff --git a/responses/templates.md b/responses/templates.md
@@ -1,4 +1,12 @@
-5: on pr.closed (learner merged)
-- bot creates PR about templates
-- challenge question: 4 different screenshots of bug reports -- which is the right one? 
-- learner answers (no right answer)
+Let's now learn about issue and pull request templates.
+
+### Challenge question
+
+Here are four different ways you could submit a bug report. Which is the _right_ way? 
+
+- [ ] [SCREENSHOT 1]
+- [ ] [SCREENSHOT 2]
+- [ ] [SCREENSHOT 3]
+- [ ] [SCREENSHOT 4]
+
+I'll respond when you check one of the boxes above. 
diff --git a/responses/welcome.md b/responses/welcome.md
@@ -1,5 +1,12 @@
-- response explains we're creating an internal innersource commons, as we work on this repo we'll be creating a resource others can use within your organization
-- response explains that this repo can continue to be used after the course is finished
-- response explains that we'll start every new issue/PR with a challenge that will hopefully explain why Innersource is important
+This repository will eventually be a working web site that you'll be able to publish internally as your own Innersource commons.
 
-Close this issue to continue.
+[IMAGE OF FINAL PRODUCT]
+
+As we work on this repo, we'll be creating a resource others can use within your organization. This repo can continue to be used after the course is finished. 
+
+This is how this course will move along:
+- every new issue or pull request will start with a challenge question
+- you'll answer the challenge question; don't worry, there are no right or wrong answers
+- the question will highlight why each topic is an important part of applying Innersource practices right
+
+Close this issue for your first challenge.
diff --git a/responses/workflows-answer.md b/responses/workflows-answer.md
@@ -1,4 +1,11 @@
-8: on issue_comment.created (learner answered)
-- bot validates
-- bot explains items in the PR, will be combinations of information about branch protections, example workflows, CODEOWNERS, deployment, etc
-- asks learner to merge 
+### Answer :crystal_ball:
+
+The real answer is that, without documentation, we don't know!
+
+This PR covers the basics, but here are some recommendations to help any contributor know the right way to open pull requests: 
+- use protected branches, doing so will allow you to accept PRs without fear of breaking production code
+- use Codeowners in combination with protected branches, to ensure that the right people are pinged for specific changes
+- if you haven't picked a workflow, use a common and well documented one that your contributors can easily search for
+- be explicit about your deployment and release strategy
+
+I'll respond when you merge this PR.
diff --git a/responses/workflows.md b/responses/workflows.md
@@ -1,4 +1,11 @@
-7: on pr.closed (learner merged)
-- bot creates PR about workflow
-- challenge: what should you name your branch? screenshot of a list of branches
-- learner answers
+This PR covers a few common workflow that are likely in use within your organization.
+
+### Challenge question
+
+I'd like to contribute to this repository. Which branch should I target my changes for? 
+- [ ] `master`
+- [ ] `release-candidate`
+- [ ] `dev`
+- [ ] Don't know
+
+I'll respond when I detect you've checked one of the boxes above. 
