refactor(search): expose repository visibility enum

Remove the derivable node_id from compact full repository search output and
publish the visibility enum in the static output schema.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: SamMorrowDrums

pkg/github/__toolsnaps__/search_repositories.snap

@@ -157,10 +157,6 @@
             "name": {
               "type": "string"
             },
-            "node_id": {
-              "description": "GraphQL node ID",
-              "type": "string"
-            },
             "open_issues_count": {
               "type": "integer"
             },
@@ -234,7 +230,12 @@
               "type": "string"
             },
             "visibility": {
-              "description": "Repository visibility: public, private, or internal",
+              "description": "Repository visibility",
+              "enum": [
+                "public",
+                "private",
+                "internal"
+              ],
               "type": "string"
             },
             "watchers_count": {

pkg/github/search.go

@@ -57,7 +57,8 @@ func SearchRepositories(t translations.TranslationHelperFunc) inventory.ServerTo
 				Title:        t("TOOL_SEARCH_REPOSITORIES_USER_TITLE", "Search repositories"),
 				ReadOnlyHint: true,
 			},
-			InputSchema: schema,
+			InputSchema:  schema,
+			OutputSchema: searchRepositoriesOutputSchema(),
 		},
 		scopes.PublicRead(scopes.Repo),
 		func(ctx context.Context, deps ToolDependencies, _ *mcp.CallToolRequest, input SearchRepositoriesInput) (*mcp.CallToolResult, *SearchRepositoriesOutput, error) {

pkg/github/search_tool_types.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 
 	"github.com/google/go-github/v92/github"
+	"github.com/google/jsonschema-go/jsonschema"
 )
 
 type SearchAccountsInput struct {
@@ -32,9 +33,8 @@ type SearchRepositoriesOutput struct {
 
 type SearchRepository struct {
 	MinimalRepository
-	NodeID         string                       `json:"node_id,omitempty" jsonschema:"GraphQL node ID"`
 	Homepage       string                       `json:"homepage,omitempty" jsonschema:"Repository homepage URL"`
-	Visibility     string                       `json:"visibility,omitempty" jsonschema:"Repository visibility: public, private, or internal"`
+	Visibility     string                       `json:"visibility,omitempty" jsonschema:"Repository visibility"`
 	PushedAt       string                       `json:"pushed_at,omitempty" jsonschema:"Last push time as an ISO 8601 UTC timestamp"`
 	WatchersCount  *int                         `json:"watchers_count,omitempty" jsonschema:"Number of watchers"`
 	Size           *int                         `json:"size,omitempty" jsonschema:"Repository size in kilobytes"`
@@ -62,6 +62,17 @@ type SearchRepositoryPermissions struct {
 	Pull     *bool `json:"pull,omitempty"`
 }
 
+var searchRepositoryVisibilityEnum = []any{"public", "private", "internal"}
+
+func searchRepositoriesOutputSchema() *jsonschema.Schema {
+	schema, err := jsonschema.For[SearchRepositoriesOutput](nil)
+	if err != nil {
+		panic(err)
+	}
+	schema.Properties["items"].Items.Properties["visibility"].Enum = searchRepositoryVisibilityEnum
+	return schema
+}
+
 func minimalSearchRepository(repo *github.Repository) MinimalRepository {
 	minimalRepo := MinimalRepository{
 		ID:            repo.GetID(),
@@ -93,7 +104,6 @@ func minimalSearchRepository(repo *github.Repository) MinimalRepository {
 func fullSearchRepository(repo *github.Repository) SearchRepository {
 	out := SearchRepository{
 		MinimalRepository: minimalSearchRepository(repo),
-		NodeID:            repo.GetNodeID(),
 		Homepage:          repo.GetHomepage(),
 		Visibility:        repo.GetVisibility(),
 		WatchersCount:     repo.WatchersCount,

pkg/github/typed_account_repository_search_test.go

@@ -195,7 +195,7 @@ func TestTypedAccountRepositorySearchOutputs(t *testing.T) {
 					var full github.RepositoriesSearchResult
 					require.NoError(t, json.Unmarshal([]byte(body), &full))
 					checkStructured(map[string]any{"minimal_output": false}, mustMarshalJSON(t, full),
-						`{"total_count":1,"incomplete_results":false,"items":[{"id":7,"name":"repo","full_name":"owner/repo","description":"<b>description</b>","html_url":"repo-url","stargazers_count":0,"forks_count":0,"open_issues_count":0,"created_at":"2026-01-02T03:04:05Z","topics":["go"],"private":false,"fork":false,"archived":false,"node_id":"R_7","homepage":"https://example.com","visibility":"public","pushed_at":"2026-01-03T03:04:05Z","watchers_count":4,"size":0,"disabled":false,"has_issues":true,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT"},"permissions":{"admin":false,"pull":true}}]}`)
+						`{"total_count":1,"incomplete_results":false,"items":[{"id":7,"name":"repo","full_name":"owner/repo","description":"<b>description</b>","html_url":"repo-url","stargazers_count":0,"forks_count":0,"open_issues_count":0,"created_at":"2026-01-02T03:04:05Z","topics":["go"],"private":false,"fork":false,"archived":false,"homepage":"https://example.com","visibility":"public","pushed_at":"2026-01-03T03:04:05Z","watchers_count":4,"size":0,"disabled":false,"has_issues":true,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT"},"permissions":{"admin":false,"pull":true}}]}`)
 					check(map[string]any{"minimal_output": true}, fixture.text)
 				}
 				for _, emptyBody := range []string{`{"total_count":0,"incomplete_results":false,"items":[]}`, `{"items":null}`, `{}`} {
@@ -266,10 +266,10 @@ func TestTypedAccountRepositorySearchOutputs(t *testing.T) {
 }
 
 func TestSearchRepositoryOutputSchemaIsCompact(t *testing.T) {
-	schema, err := jsonschema.For[SearchRepositoriesOutput](nil)
-	require.NoError(t, err)
+	schema := searchRepositoriesOutputSchema()
+	assert.Equal(t, searchRepositoryVisibilityEnum, schema.Properties["items"].Items.Properties["visibility"].Enum)
 	encoded := mustMarshalJSON(t, schema)
-	for _, field := range []string{"custom_properties", "owner", "parent", "issues_url", "clone_url", "url\""} {
+	for _, field := range []string{"node_id", "custom_properties", "owner", "parent", "issues_url", "clone_url", "url\""} {
 		assert.NotContains(t, encoded, `"`+field, field)
 	}
 	assert.Contains(t, encoded, `"html_url"`)