[fp-enhancer] Improve pkg/cli: use sliceutil.Filter/Map for functional slice operations (#19705)

Author: github-actions[bot]

pkg/cli/audit_report_analysis.go

@@ -105,10 +105,7 @@ func generateFindings(processedRun ProcessedRun, metrics MetricsData, errors []E
 
 	// Missing tool findings
 	if len(processedRun.MissingTools) > 0 {
-		toolNames := make([]string, 0, min(3, len(processedRun.MissingTools)))
-		for i := 0; i < len(processedRun.MissingTools) && i < 3; i++ {
-			toolNames = append(toolNames, processedRun.MissingTools[i].Tool)
-		}
+		toolNames := sliceutil.Map(processedRun.MissingTools[:min(3, len(processedRun.MissingTools))], func(t MissingToolReport) string { return t.Tool })
 		desc := "Missing tools: " + strings.Join(toolNames, ", ")
 		if len(processedRun.MissingTools) > 3 {
 			desc += fmt.Sprintf(" (and %d more)", len(processedRun.MissingTools)-3)

pkg/cli/firewall_log.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/github/gh-aw/pkg/console"
 	"github.com/github/gh-aw/pkg/logger"
+	"github.com/github/gh-aw/pkg/sliceutil"
 )
 
 var firewallLogLog = logger.New("cli:firewall_log")
@@ -352,14 +353,11 @@ func analyzeFirewallLogs(runDir string, verbose bool) (*FirewallAnalysis, error)
 	}
 
 	// Filter for firewall log files (they typically have "access" or "firewall" in the name)
-	var firewallLogs []string
-	for _, file := range files {
+	firewallLogs := sliceutil.Filter(files, func(file string) bool {
 		basename := filepath.Base(file)
-		if strings.Contains(basename, "firewall") ||
-			(strings.Contains(basename, "access") && !strings.Contains(basename, "access-")) {
-			firewallLogs = append(firewallLogs, file)
-		}
-	}
+		return strings.Contains(basename, "firewall") ||
+			(strings.Contains(basename, "access") && !strings.Contains(basename, "access-"))
+	})
 
 	if len(firewallLogs) == 0 {
 		firewallLogLog.Print("No firewall logs found")

pkg/cli/mcp_list_tools.go

@@ -210,12 +210,9 @@ func completeMCPListToolsArgs(cmd *cobra.Command, args []string, toComplete stri
 	// First argument: MCP server names are not easily discoverable without a workflow
 	// For now, provide no file completion but suggest common server names
 	if len(args) == 0 {
-		var filtered []string
-		for _, s := range commonMCPServerNames {
-			if toComplete == "" || strings.HasPrefix(s, toComplete) {
-				filtered = append(filtered, s)
-			}
-		}
+		filtered := sliceutil.Filter(commonMCPServerNames, func(s string) bool {
+			return toComplete == "" || strings.HasPrefix(s, toComplete)
+		})
 		return filtered, cobra.ShellCompDirectiveNoFileComp
 	}
 	// Second argument: complete workflow names