Merge pull request #22914 from aschackmull/ssa/postupdate

SSA: Refactor post-update support in DataFlowIntegration.

Author: aschackmull

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImplCommon.qll

@@ -217,6 +217,16 @@ private module IteratorIndirections {
       )
     }
 
+    // A by-value crement result loads the iterator, rather than aliasing its address.
+    override predicate isAdditionalDereference(Instruction deref, Operand address) {
+      exists(CallInstruction call |
+        deref = call and
+        call.getStaticCallTarget() instanceof Iterator::IteratorCrementMemberOperator and
+        not call.getResultType() instanceof Cpp::ReferenceType and
+        address = call.getThisArgumentOperand()
+      )
+    }
+
     override predicate isAdditionalConversionFlow(Operand opFrom, Instruction instrTo) {
       // This is a bit annoying: Consider the following snippet:
       // ```
@@ -255,11 +265,11 @@ private module IteratorIndirections {
         store.getDestinationAddress() = var
       )
       or
-      // A call to `operator++` or `operator--` is the iterator equivalent version of a
-      // pointer arithmetic instruction.
+      // A reference-returning `operator++` or `operator--` preserves the iterator's address.
       exists(CallInstruction call |
         instrTo = call and
         call.getStaticCallTarget() instanceof Iterator::IteratorCrementMemberOperator and
+        call.getResultType() instanceof Cpp::ReferenceType and
         opFrom = call.getThisArgumentOperand()
       )
     }

rust/ql/test/query-tests/diagnostics/SsaConsistencyCounts.expected

@@ -1,10 +0,0 @@
-| Definition cannot reach a read | 0 |
-| End of a basic block can be reached by multiple definitions | 0 |
-| Phi has less than 2 immediately prior references | 0 |
-| Phi node has less than two inputs | 0 |
-| Phi read has less than 2 immediately prior references | 0 |
-| Read can be reached from multiple definitions | 0 |
-| Read cannot be reached from a definition | 0 |
-| Read does not have a prior reference | 0 |
-| Read has multiple prior references | 0 |
-| Read is not dominated by a definition | 0 |