Skip to content

Commit e3fb7f8

Browse files
committed
Add failing test for no unreachable statement not in allowlist
1 parent 51f654d commit e3fb7f8

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

‎go/ql/test/query-tests/RedundantCode/UnreachableStatement/UnreachableStatement.expected‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@
1111
| main.go:153:2:153:22 | return statement | This statement is unreachable. |
1212
| main.go:159:2:159:43 | return statement | This statement is unreachable. |
1313
| main.go:171:2:171:14 | expression statement | This statement is unreachable. |
14+
| main.go:177:1:178:12 | labeled statement | This statement is unreachable. |

‎go/ql/test/query-tests/RedundantCode/UnreachableStatement/main.go‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,13 @@ func test21() {
171171
unreachable() // $ Alert
172172
}
173173

174+
func test22() {
175+
goto reachableLabel
176+
panic("unreachable") // OK: allowlisted statement
177+
reachableLabel:
178+
reachable() // $ SPURIOUS: Alert // OK: reachable through the goto
179+
}
180+
174181
func test23() {
175182
if true {
176183
return

0 commit comments

Comments
 (0)