unified: Add NameBinding.qll

Now that StaticNameBinding also has a module called 'Public' we get
conflicts when importing both. Adding a facade for importing both.

Author: asgerf

unified/ql/lib/codeql/unified/internal/AnalysisQuality.qll

@@ -1,8 +1,6 @@
 private import unified
 private import codeql.util.ReportStats
-private import codeql.unified.internal.StaticNameBinding
-private import codeql.unified.internal.LocalNameBinding
-private import codeql.unified.internal.NameBindingPlugin
+private import codeql.unified.internal.NameBinding
 
 /** Stats about name nodes that static name binding could resolve. */
 module StaticNameResolutionStats implements EntityStatsSig {

unified/ql/lib/codeql/unified/internal/NameBinding.qll

@@ -0,0 +1,15 @@
+/**
+ * Re-exports everything from the name-binding passes, while avoiding conflicts on 'Public'.
+ *
+ * TODO: move name binding passes into a subfolder.
+ */
+
+import StaticNameBinding
+import LocalNameBinding
+import NameBindingPlugin
+
+module Public {
+  // re-declare here to avoid conflicting import
+  import StaticNameBinding::Public
+  import LocalNameBinding::Public
+}

unified/ql/lib/unified.qll

@@ -7,5 +7,4 @@ import codeql.files.FileSystem
 import codeql.unified.internal.Ast::UnifiedFinal
 import codeql.unified.internal.AstExtra::Public
 import codeql.unified.internal.ControlFlowGraph
-import codeql.unified.internal.LocalNameBinding::Public
-import codeql.unified.internal.StaticNameBinding::Public
+import codeql.unified.internal.NameBinding::Public