Merge pull request #22884 from johncarmack1984/rust-actix-connection-info-neutral

Rust: Add neutral models for spurious actix-web `connection_info` sink models

Author: geoffw0

rust/ql/lib/change-notes/2026-10-25-neutral-models-actix-connection-info.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* Added neutral models to inhibit spurious generated sink models for `actix_web::HttpRequest::connection_info` and the methods built on it, such as `full_url` and `url_for`. This fixes some false positive results from queries such as `rust/uncontrolled-allocation-size` and `rust/log-injection`.

rust/ql/lib/codeql/rust/frameworks/actix-web.model.yml

@@ -15,4 +15,15 @@ extensions:
       pack: codeql/rust-all
       extensible: summaryModel
     data:
-        - ["<actix_web::types::path::Path>::into_inner", "Argument[self]", "ReturnValue", "taint", "manual"]
+        - ["<actix_web::types::path::Path>::into_inner", "Argument[self]", "ReturnValue", "taint", "manual"]
+  - addsTo:
+      pack: codeql/rust-all
+      extensible: neutralModel
+    data:
+      - ["<actix_web::info::ConnectionInfo as actix_web::extract::FromRequest>::from_request", "sink", "manual"]
+      - ["<actix_web::request::HttpRequest>::connection_info", "sink", "manual"]
+      - ["<actix_web::request::HttpRequest>::full_url", "sink", "manual"]
+      - ["<actix_web::request::HttpRequest>::url_for", "sink", "manual"]
+      - ["<actix_web::request::HttpRequest>::url_for_static", "sink", "manual"]
+      - ["<actix_web::rmap::ResourceMap>::url_for", "sink", "manual"]
+      - ["<actix_web::service::ServiceRequest>::connection_info", "sink", "manual"]