Merge pull request #22918 from MathiasVP/fix-js-parsing-set-get

JS: Fix parsing of destructuring patterns with identifiers named `set` or `get`

Author: MathiasVP

javascript/extractor/src/com/semmle/jcorn/Parser.java

@@ -2017,7 +2017,9 @@ protected void parsePropertyValue(PropertyInfo pi) {
         && pi.key instanceof Identifier
         && (((Identifier) pi.key).getName().equals("get")
             || ((Identifier) pi.key).getName().equals("set"))
-        && (this.type != TokenType.comma && this.type != TokenType.braceR)) {
+        && (this.type != TokenType.comma
+            && this.type != TokenType.braceR
+            && this.type != TokenType.eq)) {
       if (pi.isGenerator || pi.isAsync || pi.isPattern) this.unexpected();
       pi.kind = ((Identifier) pi.key).getName();
       PropertyInfo pi2 = new PropertyInfo(false, false, this.startLoc);

javascript/extractor/tests/es2015/input/property_pattern_with_default.js

@@ -1 +1,21 @@
-({x = 1}) => x;
+({x = 1}) => x;
+
+const example = ({ set = {}, unset = [] }, replacements) => {
+  return { set, unset };
+};
+({ get = {}, set = [] }) => ({ get, set });
+async ({ get = 1, set = 2 } = {}) => ({ get, set });
+
+let get, set;
+({ get = 1, set = 2 } = {});
+function defaults({ get = 1, set = 2 }) {
+  return { get, set };
+}
+
+({
+  get value() { return get; },
+  set value(v) { set = v; },
+  get,
+  set
+});
+({ get() {}, set(value) {} });