Shared: Disable dynamic join ordering for select predicates

Author: kaspersv

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

@@ -1490,6 +1490,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
 
         private module RevTypeFlow = TypeFlow<RevTypeFlowInput>;
 
+        pragma[no_dynamic_join_order]
         pragma[nomagic]
         private predicate flowIntoCallApValid(Call call, Callable c, ArgNd arg, ParamNd p, Ap ap) {
           flowIntoCallAp(call, c, arg, p, ap) and
@@ -1506,6 +1507,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
           )
         }
 
+        pragma[no_dynamic_join_order]
         private predicate revFlowIn(Call call, Callable c, ArgNd arg, Ap ap) {
           exists(ParamNd p |
             revFlow(p, TReturnCtxNone(), _, ap) and

shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll

@@ -1004,6 +1004,7 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
 
     private predicate relevantType(Type t) { t = getNodeType(_) }
 
+    pragma[no_dynamic_join_order]
     cached
     predicate isTopType(Type t) {
       strictcount(Type t0 | relevantType(t0)) =
@@ -1513,6 +1514,7 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
           Cand::argumentValueFlowsThroughCand(arg, _, _)
         }
 
+        pragma[no_dynamic_join_order]
         pragma[nomagic]
         private predicate argumentValueFlowsThrough0(
           Call call, ArgNode arg, ReturnKind kind, ReadStepTypesOption read, string model,
@@ -2132,6 +2134,7 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
      * the current data flow stage has reached the call of `arg` from one of its
      * call targets.
      */
+    pragma[no_dynamic_join_order]
     private predicate typeFlowArgTypeFromReturn(ArgNode arg, Type t) {
       exists(ParamNode p, Type t1, Type t2 |
         dataFlowTakenCallEdgeOut(_, _, arg, p) and

shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll

@@ -866,6 +866,7 @@ module RangeStage<
    * - `upper = true`  : `v <= b + delta`
    * - `upper = false` : `v >= b + delta`
    */
+  pragma[no_dynamic_join_order]
   private predicate boundedSsa(
     Sem::SsaVariable v, SemBound b, D::Delta delta, SsaReadPosition pos, boolean upper,
     boolean fromBackEdge, D::Delta origdelta, SemReason reason
@@ -1289,6 +1290,7 @@ module RangeStage<
    * - `upper = true`  : `e <= b + delta`
    * - `upper = false` : `e >= b + delta`
    */
+  pragma[no_dynamic_join_order]
   predicate initialBounded(
     Sem::Expr e, SemBound b, D::Delta delta, boolean upper, boolean fromBackEdge,
     D::Delta origdelta, SemReason reason