Skip to content

Commit 2bdc7bc

Browse files
jketemaCopilot
andcommitted
Go: Clarify registry proxy certificate handling
Document the proxy certificate behavior without referring to the previous global Git configuration, and add a Go extractor change note. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 62c944f commit 2bdc7bc

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎go/extractor/registries/registryproxy.go‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ func getEnvVars() []string {
104104
} else {
105105
proxy_cert_file = f.Name()
106106
// `SSL_CERT_FILE` is used by Go itself; `GIT_SSL_CAINFO` is used by the `git`
107-
// processes that `go` spawns to fetch `git_source` modules. Setting it here scopes
108-
// the certificate to our subprocesses instead of modifying the global git configuration.
107+
// processes that `go` spawns to fetch `git_source` modules.
109108
result = append(
110109
result,
111110
fmt.Sprintf("SSL_CERT_FILE=%s", proxy_cert_file),
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
lgtm,codescanning
2+
* The Go extractor now passes the registry proxy CA certificate to Git subprocesses, allowing private `git_source` modules to be fetched through the proxy.

0 commit comments

Comments
 (0)