From 3741b390c4360486a1b918b6a64c3f67083185db Mon Sep 17 00:00:00 2001 From: Erica Pisani Date: Tue, 6 Oct 2026 14:58:06 -0400 Subject: [PATCH] test(celery): Remove redundant empty `data_collection` from sentry_init Refs PY-2936 --- tests/integrations/celery/test_celery.py | 25 ++++-------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/tests/integrations/celery/test_celery.py b/tests/integrations/celery/test_celery.py index f7a8a23386..b332220354 100644 --- a/tests/integrations/celery/test_celery.py +++ b/tests/integrations/celery/test_celery.py @@ -114,7 +114,6 @@ def test_simple_with_performance( ): celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) @celery.task(name="dummy_task") @@ -150,7 +149,6 @@ def dummy_task(x, y): def test_simple_without_performance(capture_events, init_celery, celery_invocation): celery = init_celery( traces_sample_rate=None, - data_collection={}, ) events = capture_events() @@ -261,7 +259,6 @@ def test_transaction_events( ): celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) @celery.task(name="dummy_task") @@ -343,7 +340,7 @@ def dummy_task(): def test_simple_no_propagation(capture_events, init_celery): - celery = init_celery(propagate_traces=False, data_collection={}) + celery = init_celery(propagate_traces=False) events = capture_events() @celery.task(name="dummy_task") @@ -455,7 +452,7 @@ def test_traces_sampler_gets_task_info_in_sampling_context( DictionaryContaining, # noqa:N803 ): traces_sampler = mock.Mock(return_value=1.0) - celery = init_celery(traces_sampler=traces_sampler, data_collection={}) + celery = init_celery(traces_sampler=traces_sampler) @celery.task(name="dog_walk") def walk_dogs(x, y): @@ -527,7 +524,7 @@ def dummy_task(self, x, y): def test_baggage_propagation(init_celery): - celery = init_celery(traces_sample_rate=1.0, release="abcdef", data_collection={}) + celery = init_celery(traces_sample_rate=1.0, release="abcdef") @celery.task(name="dummy_task", bind=True) def dummy_task(self, x, y): @@ -564,7 +561,6 @@ def test_sentry_propagate_traces_override(init_celery): propagate_traces=True, traces_sample_rate=1.0, release="abcdef", - data_collection={}, ) @celery.task(name="dummy_task", bind=True) @@ -592,7 +588,6 @@ def dummy_task(self, message): def test_apply_async_manually_span(sentry_init): sentry_init( integrations=[CeleryIntegration()], - data_collection={}, ) def dummy_function(*args, **kwargs): @@ -605,7 +600,7 @@ def dummy_function(*args, **kwargs): def test_apply_async_no_args(init_celery): - celery = init_celery(data_collection={}) + celery = init_celery() @celery.task def example_task(): @@ -629,7 +624,6 @@ def test_messaging_destination_name_default_exchange( ): celery_app = init_celery( traces_sample_rate=1.0, - data_collection={}, ) mock_request.delivery_info = {"routing_key": routing_key, "exchange": ""} @@ -659,7 +653,6 @@ def test_messaging_destination_name_nondefault_exchange( """ celery_app = init_celery( traces_sample_rate=1.0, - data_collection={}, ) mock_request.delivery_info = {"routing_key": "celery", "exchange": "custom"} @@ -679,7 +672,6 @@ def task(): ... def test_messaging_id(init_celery, capture_items): celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) @celery.task @@ -698,7 +690,6 @@ def example_task(): ... def test_retry_count_zero(init_celery, capture_items): celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) @celery.task() @@ -720,7 +711,6 @@ def test_retry_count_nonzero(mock_request, init_celery, capture_items): celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) @celery.task() @@ -740,7 +730,6 @@ def task(): ... def test_messaging_system(system, init_celery, capture_items): celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) # Does not need to be a real URL, since we use always eager @@ -771,7 +760,6 @@ def publish(*args, **kwargs): sentry_init( integrations=[CeleryIntegration()], traces_sample_rate=1.0, - data_collection={}, ) celery = Celery(__name__, broker=f"{system}://example.com") # noqa: E231 @@ -801,7 +789,6 @@ def task(): ... def test_receive_latency(init_celery, capture_items): celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) @celery.task() @@ -821,7 +808,6 @@ def task(): ... def tests_span_origin_consumer(init_celery, capture_items): celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) celery.conf.broker_url = "redis://example.com" # noqa: E231 @@ -850,7 +836,6 @@ def publish(*args, **kwargs): sentry_init( integrations=[CeleryIntegration()], traces_sample_rate=1.0, - data_collection={}, ) celery = Celery(__name__, broker="redis://example.com") # noqa: E231 @@ -885,7 +870,6 @@ def test_send_task_wrapped( sentry_init( integrations=[CeleryIntegration()], traces_sample_rate=1.0, - data_collection={}, ) celery = Celery(__name__, broker="redis://example.com") # noqa: E231 @@ -937,7 +921,6 @@ def test_user_custom_headers_accessible_in_task(init_celery): """ celery = init_celery( traces_sample_rate=1.0, - data_collection={}, ) @celery.task(name="custom_headers_task", bind=True)