From 21da8da49cfbc3cdb9088b7b92197ece0076b8bd Mon Sep 17 00:00:00 2001 From: Alexander Alderman Webb Date: Wed, 30 Sep 2026 12:48:31 +0200 Subject: [PATCH] test(starlette): Expect parametrized route in starlette>=1.7 --- tests/integrations/starlette/test_starlette.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/integrations/starlette/test_starlette.py b/tests/integrations/starlette/test_starlette.py index 585cf4d541..55e2192ba1 100644 --- a/tests/integrations/starlette/test_starlette.py +++ b/tests/integrations/starlette/test_starlette.py @@ -1025,7 +1025,7 @@ def test_transaction_style( assert event["transaction_info"] == {"source": expected_source} -def test_host_route_path_has_url_source(sentry_init, capture_events): +def test_hosted_route_transaction_info(sentry_init, capture_events): sentry_init( integrations=[StarletteIntegration(transaction_style="url")], traces_sample_rate=1.0, @@ -1046,8 +1046,13 @@ async def hosted_endpoint(request): client.get("/users/123456", headers={"Host": "subapp"}) (event,) = events - assert event["transaction"].endswith("/users/123456") - assert event["transaction_info"] == {"source": "url"} + # Starlette starting setting scope["route"] with https://github.com/Kludex/starlette/commit/9c594b56e8da9c3d8c35baa40f357e7bc94f6d02 + if STARLETTE_VERSION >= (1, 7): + assert event["transaction"] == "/users/{user_id}" + assert event["transaction_info"] == {"source": "route"} + else: + assert event["transaction"].endswith("/users/123456") + assert event["transaction_info"] == {"source": "url"} @pytest.mark.parametrize(