Skip to content

Commit e96bdca

Browse files
ericapisaniericapisani
authored
test(httpx): Remove redundant empty data_collection from sentry_init (#7898)
Refs PY-2936
1 parent 26a4849 commit e96bdca

1 file changed

Lines changed: 4 additions & 43 deletions

File tree

‎tests/integrations/httpx/test_httpx.py‎

Lines changed: 4 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ def before_breadcrumb(crumb, hint):
2929
sentry_init(
3030
integrations=[HttpxIntegration()],
3131
before_breadcrumb=before_breadcrumb,
32-
data_collection={},
3332
)
3433

3534
url = "http://example.com/"
@@ -71,7 +70,6 @@ def before_breadcrumb(crumb, hint):
7170
sentry_init(
7271
integrations=[HttpxIntegration()],
7372
before_breadcrumb=before_breadcrumb,
74-
data_collection={},
7573
)
7674

7775
url = "http://example.com/"
@@ -105,10 +103,7 @@ def before_breadcrumb(crumb, hint):
105103
def test_crumb_capture_without_span_sync(sentry_init, capture_events, httpx_mock):
106104
httpx_mock.add_response()
107105

108-
sentry_init(
109-
integrations=[HttpxIntegration()],
110-
data_collection={},
111-
)
106+
sentry_init(integrations=[HttpxIntegration()])
112107

113108
url = "http://example.com/"
114109

@@ -141,10 +136,7 @@ async def test_crumb_capture_without_span_async(
141136
):
142137
httpx_mock.add_response()
143138

144-
sentry_init(
145-
integrations=[HttpxIntegration()],
146-
data_collection={},
147-
)
139+
sentry_init(integrations=[HttpxIntegration()])
148140

149141
url = "http://example.com/"
150142

@@ -186,10 +178,7 @@ def test_crumb_capture_client_error_sync(
186178
):
187179
httpx_mock.add_response(status_code=status_code)
188180

189-
sentry_init(
190-
integrations=[HttpxIntegration()],
191-
data_collection={},
192-
)
181+
sentry_init(integrations=[HttpxIntegration()])
193182

194183
url = "http://example.com/"
195184

@@ -239,10 +228,7 @@ async def test_crumb_capture_client_error_async(
239228
):
240229
httpx_mock.add_response(status_code=status_code)
241230

242-
sentry_init(
243-
integrations=[HttpxIntegration()],
244-
data_collection={},
245-
)
231+
sentry_init(integrations=[HttpxIntegration()])
246232

247233
url = "http://example.com/"
248234

@@ -340,7 +326,6 @@ def test_option_trace_propagation_targets_sync(
340326
trace_propagation_targets=trace_propagation_targets,
341327
traces_sample_rate=1.0,
342328
integrations=[HttpxIntegration()],
343-
data_collection={},
344329
)
345330

346331
httpx.Client().get(url)
@@ -418,7 +403,6 @@ async def test_option_trace_propagation_targets_async(
418403
trace_propagation_targets=trace_propagation_targets,
419404
traces_sample_rate=1.0,
420405
integrations=[HttpxIntegration()],
421-
data_collection={},
422406
)
423407

424408
await httpx.AsyncClient().get(url)
@@ -437,7 +421,6 @@ def test_outgoing_trace_headers_sync(sentry_init, capture_items, httpx_mock):
437421
sentry_init(
438422
traces_sample_rate=1.0,
439423
integrations=[HttpxIntegration()],
440-
data_collection={},
441424
)
442425

443426
url = "http://example.com/"
@@ -467,7 +450,6 @@ async def test_outgoing_trace_headers_async(sentry_init, capture_items, httpx_mo
467450
sentry_init(
468451
traces_sample_rate=1.0,
469452
integrations=[HttpxIntegration()],
470-
data_collection={},
471453
)
472454

473455
url = "http://example.com/"
@@ -499,7 +481,6 @@ def test_outgoing_trace_headers_append_to_baggage_sync(
499481
traces_sample_rate=1.0,
500482
integrations=[HttpxIntegration()],
501483
release="d08ebdb9309e1b004c6f52202de58a09c2268e42",
502-
data_collection={},
503484
)
504485

505486
url = "http://example.com/"
@@ -531,7 +512,6 @@ async def test_outgoing_trace_headers_append_to_baggage_async(
531512
traces_sample_rate=1.0,
532513
integrations=[HttpxIntegration()],
533514
release="d08ebdb9309e1b004c6f52202de58a09c2268e42",
534-
data_collection={},
535515
)
536516

537517
url = "http://example.com/"
@@ -572,7 +552,6 @@ def test_outgoing_trace_headers_no_current_span(sentry_init, httpx_mock):
572552
traces_sample_rate=1.0,
573553
trace_propagation_targets=[MATCH_ALL],
574554
integrations=[HttpxIntegration()],
575-
data_collection={},
576555
)
577556

578557
url = "http://example.com/"
@@ -609,7 +588,6 @@ async def test_outgoing_trace_headers_no_current_span_async(sentry_init, httpx_m
609588
traces_sample_rate=1.0,
610589
trace_propagation_targets=[MATCH_ALL],
611590
integrations=[HttpxIntegration()],
612-
data_collection={},
613591
)
614592

615593
url = "http://example.com/"
@@ -641,7 +619,6 @@ def test_request_source_disabled_sync(sentry_init, capture_items, httpx_mock):
641619
traces_sample_rate=1.0,
642620
enable_http_request_source=False,
643621
http_request_source_threshold_ms=0,
644-
data_collection={},
645622
)
646623

647624
items = capture_items("span")
@@ -670,7 +647,6 @@ async def test_request_source_disabled_async(sentry_init, capture_items, httpx_m
670647
traces_sample_rate=1.0,
671648
enable_http_request_source=False,
672649
http_request_source_threshold_ms=0,
673-
data_collection={},
674650
)
675651

676652
items = capture_items("span")
@@ -707,7 +683,6 @@ def test_request_source_enabled_sync(
707683
integrations=[HttpxIntegration()],
708684
traces_sample_rate=1.0,
709685
http_request_source_threshold_ms=0,
710-
data_collection={},
711686
**kwargs,
712687
)
713688

@@ -743,7 +718,6 @@ async def test_request_source_enabled_async(
743718
integrations=[HttpxIntegration()],
744719
traces_sample_rate=1.0,
745720
http_request_source_threshold_ms=0,
746-
data_collection={},
747721
**kwargs,
748722
)
749723

@@ -772,7 +746,6 @@ def test_request_source_sync(sentry_init, capture_items, httpx_mock):
772746
traces_sample_rate=1.0,
773747
enable_http_request_source=True,
774748
http_request_source_threshold_ms=0,
775-
data_collection={},
776749
)
777750

778751
items = capture_items("span")
@@ -816,7 +789,6 @@ async def test_request_source_async(sentry_init, capture_items, httpx_mock):
816789
traces_sample_rate=1.0,
817790
enable_http_request_source=True,
818791
http_request_source_threshold_ms=0,
819-
data_collection={},
820792
)
821793

822794
items = capture_items("span")
@@ -866,7 +838,6 @@ def test_request_source_with_module_in_search_path_sync(
866838
traces_sample_rate=1.0,
867839
enable_http_request_source=True,
868840
http_request_source_threshold_ms=0,
869-
data_collection={},
870841
)
871842

872843
items = capture_items("span")
@@ -912,7 +883,6 @@ async def test_request_source_with_module_in_search_path_async(
912883
traces_sample_rate=1.0,
913884
enable_http_request_source=True,
914885
http_request_source_threshold_ms=0,
915-
data_collection={},
916886
)
917887

918888
items = capture_items("span")
@@ -958,7 +928,6 @@ def test_no_request_source_if_duration_too_short_sync(
958928
enable_http_request_source=True,
959929
# Threshold so high no real request will ever exceed it
960930
http_request_source_threshold_ms=9999999,
961-
data_collection={},
962931
)
963932

964933
items = capture_items("span")
@@ -990,7 +959,6 @@ async def test_no_request_source_if_duration_too_short_async(
990959
enable_http_request_source=True,
991960
# Threshold so high no real request will ever exceed it
992961
http_request_source_threshold_ms=9999999,
993-
data_collection={},
994962
)
995963

996964
items = capture_items("span")
@@ -1021,7 +989,6 @@ def test_request_source_if_duration_over_threshold_sync(
1021989
enable_http_request_source=True,
1022990
# Threshold of 0 means any non-zero duration qualifies
1023991
http_request_source_threshold_ms=0,
1024-
data_collection={},
1025992
)
1026993

1027994
items = capture_items("span")
@@ -1071,7 +1038,6 @@ async def test_request_source_if_duration_over_threshold_async(
10711038
enable_http_request_source=True,
10721039
# Threshold of 0 means any non-zero duration qualifies
10731040
http_request_source_threshold_ms=0,
1074-
data_collection={},
10751041
)
10761042

10771043
items = capture_items("span")
@@ -1115,7 +1081,6 @@ def test_span_origin_sync(sentry_init, capture_items, httpx_mock):
11151081
sentry_init(
11161082
integrations=[HttpxIntegration()],
11171083
traces_sample_rate=1.0,
1118-
data_collection={},
11191084
)
11201085

11211086
items = capture_items("span")
@@ -1139,7 +1104,6 @@ async def test_span_origin_async(sentry_init, capture_items, httpx_mock):
11391104
sentry_init(
11401105
integrations=[HttpxIntegration()],
11411106
traces_sample_rate=1.0,
1142-
data_collection={},
11431107
)
11441108

11451109
items = capture_items("span")
@@ -1275,7 +1239,6 @@ def test_http_url_attributes_no_query_or_fragment_sync(
12751239
sentry_init(
12761240
integrations=[HttpxIntegration()],
12771241
traces_sample_rate=1.0,
1278-
data_collection={},
12791242
)
12801243

12811244
items = capture_items("span")
@@ -1305,7 +1268,6 @@ async def test_http_url_attributes_no_query_or_fragment_async(
13051268
sentry_init(
13061269
integrations=[HttpxIntegration()],
13071270
traces_sample_rate=1.0,
1308-
data_collection={},
13091271
)
13101272

13111273
items = capture_items("span")
@@ -1595,7 +1557,6 @@ def test_omit_url_data_if_parsing_fails(
15951557
sentry_init(
15961558
integrations=[HttpxIntegration()],
15971559
traces_sample_rate=1.0,
1598-
data_collection={},
15991560
)
16001561

16011562
items = capture_items("span")

0 commit comments

Comments
 (0)