Skip to content

Commit bcce1b4

Browse files
chore(mcp): Replace deprecated mcp.tool.name with gen_ai.tool.name
1 parent e6bb84e commit bcce1b4

4 files changed

Lines changed: 11 additions & 8 deletions

File tree

‎sentry_sdk/consts.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,6 +1087,9 @@ class SPANDATA:
10871087

10881088
MCP_TOOL_NAME = "mcp.tool.name"
10891089
"""
1090+
.. deprecated::
1091+
This attribute is deprecated. Use GEN_AI_TOOL_NAME instead.
1092+
10901093
The name of the MCP tool being called.
10911094
Example: "get_weather"
10921095
"""

‎sentry_sdk/integrations/mcp.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ async def _instrument_tool_call(
261261
_set_span_input_data(
262262
span,
263263
handler_name,
264-
SPANDATA.MCP_TOOL_NAME,
264+
SPANDATA.GEN_AI_TOOL_NAME,
265265
"tools/call",
266266
arguments,
267267
request_id,

‎tests/integrations/fastmcp/test_fastmcp.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ def add_numbers(a: int, b: int) -> dict:
312312
assert span["attributes"]["sentry.op"] == OP.MCP_SERVER
313313
assert span["attributes"]["sentry.origin"] == "auto.ai.mcp"
314314
assert span["name"] == "tools/call add_numbers"
315-
assert span["attributes"][SPANDATA.MCP_TOOL_NAME] == "add_numbers"
315+
assert span["attributes"][SPANDATA.GEN_AI_TOOL_NAME] == "add_numbers"
316316
assert span["attributes"][SPANDATA.MCP_METHOD_NAME] == "tools/call"
317317
assert span["attributes"][SPANDATA.MCP_TRANSPORT] == "stdio"
318318
assert span["attributes"][SPANDATA.MCP_REQUEST_ID] == "req-123"
@@ -369,7 +369,7 @@ def add_numbers(a: int, b: int) -> dict:
369369
assert span["attributes"]["sentry.op"] == OP.MCP_SERVER
370370
assert span["attributes"]["sentry.origin"] == "auto.ai.mcp"
371371
assert span["name"] == "tools/call add_numbers"
372-
assert span["attributes"][SPANDATA.MCP_TOOL_NAME] == "add_numbers"
372+
assert span["attributes"][SPANDATA.GEN_AI_TOOL_NAME] == "add_numbers"
373373
assert span["attributes"][SPANDATA.MCP_METHOD_NAME] == "tools/call"
374374
assert span["attributes"][SPANDATA.MCP_TRANSPORT] == "stdio"
375375
assert span["attributes"][SPANDATA.MCP_REQUEST_ID] == "req-123"

‎tests/integrations/mcp/test_mcp.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ async def test_tool(ctx, params):
169169
assert span is not None
170170
data = span["attributes"]
171171

172-
assert data[SPANDATA.MCP_TOOL_NAME] == "calculate"
172+
assert data[SPANDATA.GEN_AI_TOOL_NAME] == "calculate"
173173
assert data[SPANDATA.MCP_METHOD_NAME] == "tools/call"
174174
assert data[SPANDATA.MCP_REQUEST_ID] == "req-ctor"
175175

@@ -305,7 +305,7 @@ async def test_tool(ctx, params):
305305
assert data["sentry.origin"] == "auto.ai.mcp"
306306

307307
# Check span data
308-
assert data[SPANDATA.MCP_TOOL_NAME] == "calculate"
308+
assert data[SPANDATA.GEN_AI_TOOL_NAME] == "calculate"
309309
assert data[SPANDATA.MCP_METHOD_NAME] == "tools/call"
310310
assert data[SPANDATA.MCP_TRANSPORT] == "stdio"
311311
assert data[SPANDATA.NETWORK_TRANSPORT] == "pipe"
@@ -381,7 +381,7 @@ async def test_tool(ctx, params):
381381
assert data["sentry.origin"] == "auto.ai.mcp"
382382

383383
# Check span data
384-
assert data[SPANDATA.MCP_TOOL_NAME] == "calculate"
384+
assert data[SPANDATA.GEN_AI_TOOL_NAME] == "calculate"
385385
assert data[SPANDATA.MCP_METHOD_NAME] == "tools/call"
386386
assert data[SPANDATA.MCP_TRANSPORT] == "stdio"
387387
assert data[SPANDATA.NETWORK_TRANSPORT] == "pipe"
@@ -456,7 +456,7 @@ async def test_tool_async(ctx, params):
456456
assert data["sentry.origin"] == "auto.ai.mcp"
457457

458458
# Check span data
459-
assert data[SPANDATA.MCP_TOOL_NAME] == "process"
459+
assert data[SPANDATA.GEN_AI_TOOL_NAME] == "process"
460460
assert data[SPANDATA.MCP_METHOD_NAME] == "tools/call"
461461
assert data[SPANDATA.MCP_TRANSPORT] == "http"
462462
assert data[SPANDATA.NETWORK_TRANSPORT] == "tcp"
@@ -533,7 +533,7 @@ async def test_tool_async(ctx, params):
533533
assert data["sentry.origin"] == "auto.ai.mcp"
534534

535535
# Check span data
536-
assert data[SPANDATA.MCP_TOOL_NAME] == "process"
536+
assert data[SPANDATA.GEN_AI_TOOL_NAME] == "process"
537537
assert data[SPANDATA.MCP_METHOD_NAME] == "tools/call"
538538
assert data[SPANDATA.MCP_TRANSPORT] == "http"
539539
assert data[SPANDATA.NETWORK_TRANSPORT] == "tcp"

0 commit comments

Comments
 (0)