Skip to content

Commit aedef1d

Browse files
authored
tests(aiohttp): Remove redundant empty data_collection from sentry_init (#7895)
Refs PY-2936
1 parent e7a481c commit aedef1d

1 file changed

Lines changed: 9 additions & 36 deletions

File tree

‎tests/integrations/aiohttp/test_aiohttp.py‎

Lines changed: 9 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
@pytest.mark.asyncio
3535
async def test_basic(sentry_init, aiohttp_client, capture_events):
36-
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
36+
sentry_init(integrations=[AioHttpIntegration()])
3737

3838
async def hello(request):
3939
1 / 0
@@ -74,7 +74,7 @@ async def hello(request):
7474
async def test_post_body_not_read(sentry_init, aiohttp_client, capture_events):
7575
from sentry_sdk.integrations.aiohttp import BODY_NOT_READ_MESSAGE
7676

77-
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
77+
sentry_init(integrations=[AioHttpIntegration()])
7878

7979
body = {"some": "value"}
8080

@@ -102,7 +102,7 @@ async def hello(request):
102102

103103
@pytest.mark.asyncio
104104
async def test_post_body_read(sentry_init, aiohttp_client, capture_events):
105-
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
105+
sentry_init(integrations=[AioHttpIntegration()])
106106

107107
body = {"some": "value"}
108108

@@ -232,7 +232,7 @@ async def hello(request):
232232

233233
@pytest.mark.asyncio
234234
async def test_403_not_captured(sentry_init, aiohttp_client, capture_events):
235-
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
235+
sentry_init(integrations=[AioHttpIntegration()])
236236

237237
async def hello(request):
238238
raise web.HTTPForbidden()
@@ -253,7 +253,7 @@ async def hello(request):
253253
async def test_cancelled_error_not_captured(
254254
sentry_init, aiohttp_client, capture_events
255255
):
256-
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
256+
sentry_init(integrations=[AioHttpIntegration()])
257257

258258
async def hello(request):
259259
raise asyncio.CancelledError()
@@ -276,7 +276,7 @@ async def hello(request):
276276
async def test_half_initialized(sentry_init, aiohttp_client, capture_events):
277277
# Note: the first sentry_init is intentional
278278
sentry_init()
279-
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
279+
sentry_init(integrations=[AioHttpIntegration()])
280280

281281
async def hello(request):
282282
return web.Response(text="hello")
@@ -299,7 +299,6 @@ async def test_tracing_unparseable_url(sentry_init, aiohttp_client, capture_item
299299
sentry_init(
300300
integrations=[AioHttpIntegration()],
301301
traces_sample_rate=1.0,
302-
data_collection={},
303302
)
304303

305304
async def hello(request):
@@ -336,7 +335,6 @@ async def test_traces_sampler_gets_request_object_in_sampling_context(
336335
sentry_init(
337336
integrations=[AioHttpIntegration()],
338337
traces_sampler=traces_sampler,
339-
data_collection={},
340338
)
341339

342340
async def kangaroo_handler(request):
@@ -366,7 +364,6 @@ async def test_has_trace_if_performance_enabled(
366364
sentry_init(
367365
integrations=[AioHttpIntegration()],
368366
traces_sample_rate=1.0,
369-
data_collection={},
370367
)
371368

372369
async def hello(request):
@@ -417,7 +414,7 @@ async def hello(request):
417414
async def test_has_trace_if_performance_disabled(
418415
sentry_init, aiohttp_client, capture_events
419416
):
420-
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
417+
sentry_init(integrations=[AioHttpIntegration()])
421418

422419
async def hello(request):
423420
capture_message("It's a good day to try dividing by 0")
@@ -453,7 +450,6 @@ async def test_trace_from_headers_if_performance_enabled(
453450
sentry_init(
454451
integrations=[AioHttpIntegration()],
455452
traces_sample_rate=1.0,
456-
data_collection={},
457453
)
458454

459455
async def hello(request):
@@ -507,7 +503,7 @@ async def hello(request):
507503
async def test_trace_from_headers_if_performance_disabled(
508504
sentry_init, aiohttp_client, capture_events
509505
):
510-
sentry_init(integrations=[AioHttpIntegration()], data_collection={})
506+
sentry_init(integrations=[AioHttpIntegration()])
511507

512508
async def hello(request):
513509
capture_message("It's a good day to try dividing by 0")
@@ -678,7 +674,6 @@ async def test_outgoing_trace_headers_adds_missing_unsigned_propagation_headers(
678674
sentry_init(
679675
integrations=[AioHttpIntegration()],
680676
traces_sample_rate=1.0,
681-
data_collection={},
682677
)
683678

684679
async def handler(request):
@@ -721,7 +716,6 @@ async def test_outgoing_trace_headers_appends_baggage_but_preserves_sentry_trace
721716
integrations=[AioHttpIntegration()],
722717
traces_sample_rate=1.0,
723718
release="d08ebdb9309e1b004c6f52202de58a09c2268e42",
724-
data_collection={},
725719
)
726720

727721
async def handler(request):
@@ -755,7 +749,6 @@ async def test_outgoing_trace_headers_preserves_signed_propagation_headers(
755749
sentry_init(
756750
integrations=[AioHttpIntegration()],
757751
traces_sample_rate=1.0,
758-
data_collection={},
759752
)
760753

761754
async def handler(request):
@@ -795,7 +788,6 @@ async def test_outgoing_trace_headers_preserves_query_signed_baggage(
795788
sentry_init(
796789
integrations=[AioHttpIntegration()],
797790
traces_sample_rate=1.0,
798-
data_collection={},
799791
)
800792

801793
async def handler(request):
@@ -836,7 +828,6 @@ async def test_request_source_disabled(
836828
traces_sample_rate=1.0,
837829
enable_http_request_source=False,
838830
http_request_source_threshold_ms=0,
839-
data_collection={},
840831
)
841832

842833
# server for making span request
@@ -887,7 +878,6 @@ async def test_request_source_enabled(
887878
integrations=[AioHttpIntegration()],
888879
traces_sample_rate=1.0,
889880
http_request_source_threshold_ms=0,
890-
data_collection={},
891881
**extra_options,
892882
)
893883

@@ -931,7 +921,6 @@ async def test_request_source(
931921
traces_sample_rate=1.0,
932922
enable_http_request_source=True,
933923
http_request_source_threshold_ms=0,
934-
data_collection={},
935924
)
936925

937926
# server for making span request
@@ -992,7 +981,6 @@ async def test_request_source_with_module_in_search_path(
992981
traces_sample_rate=1.0,
993982
enable_http_request_source=True,
994983
http_request_source_threshold_ms=0,
995-
data_collection={},
996984
)
997985

998986
# server for making span request
@@ -1047,7 +1035,6 @@ async def test_no_request_source_if_duration_too_short(
10471035
traces_sample_rate=1.0,
10481036
enable_http_request_source=True,
10491037
http_request_source_threshold_ms=10**10,
1050-
data_collection={},
10511038
)
10521039

10531040
# server for making span request
@@ -1093,7 +1080,6 @@ async def test_request_source_if_duration_over_threshold(
10931080
traces_sample_rate=1.0,
10941081
enable_http_request_source=True,
10951082
http_request_source_threshold_ms=0,
1096-
data_collection={},
10971083
)
10981084

10991085
# server for making span request
@@ -1152,7 +1138,6 @@ async def test_span_origin(
11521138
sentry_init(
11531139
integrations=[AioHttpIntegration()],
11541140
traces_sample_rate=1.0,
1155-
data_collection={},
11561141
)
11571142

11581143
# server for making span request
@@ -1221,9 +1206,7 @@ async def test_failed_request_status_codes(
12211206
exception_to_raise,
12221207
should_capture,
12231208
):
1224-
sentry_init(
1225-
integrations=[AioHttpIntegration(**integration_kwargs)], data_collection={}
1226-
)
1209+
sentry_init(integrations=[AioHttpIntegration(**integration_kwargs)])
12271210
events = capture_events()
12281211

12291212
async def handle(_):
@@ -1259,7 +1242,6 @@ async def test_failed_request_status_codes_with_returned_status(
12591242
"""
12601243
sentry_init(
12611244
integrations=[AioHttpIntegration(failed_request_status_codes={500})],
1262-
data_collection={},
12631245
)
12641246
events = capture_events()
12651247

@@ -1286,7 +1268,6 @@ async def test_failed_request_status_codes_non_http_exception(
12861268
"""
12871269
sentry_init(
12881270
integrations=[AioHttpIntegration(failed_request_status_codes=set())],
1289-
data_collection={},
12901271
)
12911272
events = capture_events()
12921273

@@ -1309,7 +1290,6 @@ async def test_tracing(sentry_init, aiohttp_client, capture_items):
13091290
sentry_init(
13101291
integrations=[AioHttpIntegration()],
13111292
traces_sample_rate=1.0,
1312-
data_collection={},
13131293
)
13141294

13151295
async def hello(request):
@@ -1402,7 +1382,6 @@ async def test_sensitive_header_scrubbing(sentry_init, aiohttp_client, capture_i
14021382
sentry_init(
14031383
integrations=[AioHttpIntegration()],
14041384
traces_sample_rate=1.0,
1405-
data_collection={},
14061385
)
14071386

14081387
async def hello(request):
@@ -1447,7 +1426,6 @@ async def test_transaction_style(
14471426
sentry_init(
14481427
integrations=[AioHttpIntegration()],
14491428
traces_sample_rate=1.0,
1450-
data_collection={},
14511429
)
14521430

14531431
async def hello(request):
@@ -1489,7 +1467,6 @@ async def test_http_route(
14891467
sentry_init(
14901468
integrations=[AioHttpIntegration()],
14911469
traces_sample_rate=1.0,
1492-
data_collection={},
14931470
)
14941471

14951472
async def hello(request):
@@ -1513,7 +1490,6 @@ async def test_server_error(sentry_init, aiohttp_client, capture_items):
15131490
sentry_init(
15141491
integrations=[AioHttpIntegration()],
15151492
traces_sample_rate=1.0,
1516-
data_collection={},
15171493
)
15181494

15191495
async def hello(request):
@@ -1552,7 +1528,6 @@ async def test_http_exception(sentry_init, aiohttp_client, capture_items):
15521528
sentry_init(
15531529
integrations=[AioHttpIntegration()],
15541530
traces_sample_rate=1.0,
1555-
data_collection={},
15561531
)
15571532

15581533
async def hello(request):
@@ -1584,7 +1559,6 @@ async def test_http_exception_ok_status_not_overridden(
15841559
sentry_init(
15851560
integrations=[AioHttpIntegration()],
15861561
traces_sample_rate=1.0,
1587-
data_collection={},
15881562
)
15891563

15901564
async def hello(request):
@@ -1689,7 +1663,6 @@ async def test_outgoing_trace_headers(
16891663
sentry_init(
16901664
integrations=[AioHttpIntegration()],
16911665
traces_sample_rate=1.0,
1692-
data_collection={},
16931666
)
16941667

16951668
async def handler(request):

0 commit comments

Comments
 (0)