ref(asgi)!: Drop send_default_pii support when setting user IP address (#7818)

Always gate the `user.ip_address` span attribute on
`data_collection["user_info"]` instead of falling back to
`send_default_pii` when `data_collection` isn't enabled.

Update the FastAPI form-data test to use `data_collection` rather than
`send_default_pii`.

Refs PY-2798
Refs #7566

Author: ericapisani

sentry_sdk/integrations/asgi.py

@@ -26,7 +26,7 @@
 from sentry_sdk.integrations._wsgi_common import (
     DEFAULT_HTTP_METHODS_TO_CAPTURE,
 )
-from sentry_sdk.scope import Scope, should_send_default_pii
+from sentry_sdk.scope import Scope
 from sentry_sdk.sessions import track_session
 from sentry_sdk.traces import (
     SegmentNameSource,
@@ -37,7 +37,6 @@
     _is_localhost,
     capture_internal_exceptions,
     event_from_exception,
-    has_data_collection_enabled,
     logger,
     reraise,
 )
@@ -226,10 +225,7 @@ async def _run_app(
                     ip = _get_ip(scope)
                     if ip:
                         client_options = sentry_sdk.get_client().options
-                        if has_data_collection_enabled(client_options):
-                            if client_options["data_collection"]["user_info"]:
-                                sentry_scope.set_attribute(SPANDATA.USER_IP_ADDRESS, ip)
-                        elif should_send_default_pii():
+                        if client_options["data_collection"]["user_info"]:
                             sentry_scope.set_attribute(SPANDATA.USER_IP_ADDRESS, ip)
 
                     if ty in ("http", "websocket"):

tests/integrations/fastapi/test_fastapi.py

@@ -169,7 +169,7 @@ async def test_request_info_json_body(sentry_init, capture_items):
 async def test_formdata_request_body(sentry_init, capture_items):
     sentry_init(
         traces_sample_rate=1.0,
-        send_default_pii=True,
+        data_collection={},
         max_request_body_size="always",
         integrations=[StarletteIntegration()],
     )