Skip to content

Commit 21da8da

Browse files
test(starlette): Expect parametrized route in starlette>=1.7
1 parent 2a499ec commit 21da8da

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

‎tests/integrations/starlette/test_starlette.py‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,7 +1025,7 @@ def test_transaction_style(
10251025
assert event["transaction_info"] == {"source": expected_source}
10261026

10271027

1028-
def test_host_route_path_has_url_source(sentry_init, capture_events):
1028+
def test_hosted_route_transaction_info(sentry_init, capture_events):
10291029
sentry_init(
10301030
integrations=[StarletteIntegration(transaction_style="url")],
10311031
traces_sample_rate=1.0,
@@ -1046,8 +1046,13 @@ async def hosted_endpoint(request):
10461046
client.get("/users/123456", headers={"Host": "subapp"})
10471047

10481048
(event,) = events
1049-
assert event["transaction"].endswith("/users/123456")
1050-
assert event["transaction_info"] == {"source": "url"}
1049+
# Starlette starting setting scope["route"] with https://github.com/Kludex/starlette/commit/9c594b56e8da9c3d8c35baa40f357e7bc94f6d02
1050+
if STARLETTE_VERSION >= (1, 7):
1051+
assert event["transaction"] == "/users/{user_id}"
1052+
assert event["transaction_info"] == {"source": "route"}
1053+
else:
1054+
assert event["transaction"].endswith("/users/123456")
1055+
assert event["transaction_info"] == {"source": "url"}
10511056

10521057

10531058
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)