Repository navigation
Commit 1ac2faf
authored
ref: Remove helpers left over from EventScrubber removal (#8158)
### Description
Removes two helpers that only `EventScrubber` used:
- `iter_event_frames()` in `sentry_sdk/utils.py`
- `AnnotatedValue.substituted_because_contains_sensitive_data()` in
`sentry_sdk/_types.py`
#7772 ("Remove `EventScrubber` and the `event_scrubber` option") deleted
`sentry_sdk/scrubber.py`, which held the only call to each of them:
frame-vars scrubbing called `iter_event_frames(event)`, and denylisted
keys were replaced with
`AnnotatedValue.substituted_because_contains_sensitive_data()`. Both
helpers were left behind.
**Evidence**
- On `major/3.0`, `git grep -w` for each name matches only its
definition. There are no callers in `sentry_sdk`, `tests`, `scripts` or
`docs`.
- No open PR touches either one.
`iter_event_stacktraces()` (used by `handle_in_app`) and
`SENSITIVE_DATA_SUBSTITUTE` (used by the data-collection filtering and
several integrations) are still used, so they stay.
On `master`, `EventScrubber` still uses both helpers, so this only
applies to `major/3.0`. `iter_event_frames` could be imported from
`sentry_sdk.utils`, but it isn't documented anywhere, and `major/3.0` is
already a breaking release.
#### Issues
n/a
<!-- junior-request-attribution:start -->
via **Ivana Kellyer**.
<!-- junior-request-attribution:end -->
<!-- junior-session-footer:start -->
<!-- junior-conversation-id:slack%3AC0BTREZTS2Z%3A1793270559.842119 -->
--
[View Junior
Session](https://junior-prod.sentry.dev/conversations/slack%3AC0BTREZTS2Z%3A1793270559.842119)
[[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0BTREZTS2Z%3A1793270559.842119/?project=4510944073809921)
<!-- junior-session-footer:end -->
Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>1 parent f58c75b commit 1ac2faf
2 files changed
Lines changed: 0 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | 115 | | |
131 | 116 | | |
132 | 117 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
986 | 986 | | |
987 | 987 | | |
988 | 988 | | |
989 | | - | |
990 | | - | |
991 | | - | |
992 | | - | |
993 | | - | |
994 | | - | |
995 | | - | |
996 | | - | |
997 | | - | |
998 | 989 | | |
999 | 990 | | |
1000 | 991 | | |
| |||
0 commit comments