Skip to content

Commit 10f09dc

Browse files
committed
test(quart): Remove redundant empty data_collection from sentry_init
Refs PY-2936
1 parent 3cdae4b commit 10f09dc

1 file changed

Lines changed: 12 additions & 22 deletions

File tree

‎tests/integrations/quart/test_quart.py‎

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ async def test_quart_flask_patch(sentry_init, capture_events, reset_integrations
113113
app = quart_app_factory()
114114
sentry_init(
115115
integrations=[quart_sentry.QuartIntegration()],
116-
data_collection={},
117116
)
118117

119118
@app.route("/")
@@ -134,7 +133,7 @@ async def index():
134133

135134
@pytest.mark.asyncio
136135
async def test_has_context(sentry_init, capture_events):
137-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
136+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
138137
app = quart_app_factory()
139138
events = capture_events()
140139

@@ -156,7 +155,6 @@ async def test_http_route(
156155
sentry_init(
157156
integrations=[quart_sentry.QuartIntegration()],
158157
traces_sample_rate=1.0,
159-
data_collection={},
160158
)
161159

162160
app = quart_app_factory()
@@ -178,7 +176,7 @@ async def test_errors(
178176
capture_events,
179177
integration_enabled_params,
180178
):
181-
sentry_init(data_collection={}, **integration_enabled_params)
179+
sentry_init(**integration_enabled_params)
182180
app = quart_app_factory()
183181

184182
@app.route("/")
@@ -205,7 +203,7 @@ async def index():
205203
async def test_quart_auth_not_installed(
206204
sentry_init, capture_events, monkeypatch, integration_enabled_params
207205
):
208-
sentry_init(data_collection={}, **integration_enabled_params)
206+
sentry_init(**integration_enabled_params)
209207
app = quart_app_factory()
210208

211209
monkeypatch.setattr(quart_sentry, "quart_auth", None)
@@ -270,7 +268,7 @@ async def login():
270268
],
271269
)
272270
async def test_errors_not_reported_twice(sentry_init, integrations, capture_events):
273-
sentry_init(integrations=integrations, data_collection={})
271+
sentry_init(integrations=integrations)
274272
app = quart_app_factory()
275273

276274
@app.route("/")
@@ -298,7 +296,6 @@ async def test_logging(sentry_init, capture_events):
298296
quart_sentry.QuartIntegration(),
299297
LoggingIntegration(event_level="ERROR"),
300298
],
301-
data_collection={},
302299
)
303300
app = quart_app_factory()
304301

@@ -318,7 +315,7 @@ async def index():
318315

319316
@pytest.mark.asyncio
320317
async def test_no_errors_without_request(sentry_init):
321-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
318+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
322319
app = quart_app_factory()
323320

324321
async with app.app_context():
@@ -345,7 +342,7 @@ def foo():
345342

346343
@pytest.mark.asyncio
347344
async def test_500(sentry_init):
348-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
345+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
349346
app = quart_app_factory()
350347

351348
@app.route("/")
@@ -364,7 +361,7 @@ async def error_handler(err):
364361

365362
@pytest.mark.asyncio
366363
async def test_error_in_errorhandler(sentry_init, capture_events):
367-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
364+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
368365
app = quart_app_factory()
369366

370367
@app.route("/")
@@ -428,7 +425,7 @@ async def error_handler(err):
428425
async def test_bad_request_not_captured(sentry_init, capture_events):
429426
from quart import abort
430427

431-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
428+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
432429
app = quart_app_factory()
433430
events = capture_events()
434431

@@ -447,7 +444,7 @@ async def index():
447444
async def test_does_not_leak_scope(sentry_init, capture_events):
448445
from quart import Response, stream_with_context
449446

450-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
447+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
451448
app = quart_app_factory()
452449
events = capture_events()
453450

@@ -476,7 +473,7 @@ async def generate():
476473

477474
@pytest.mark.asyncio
478475
async def test_scoped_test_client(sentry_init):
479-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
476+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
480477
app = quart_app_factory()
481478

482479
@app.route("/")
@@ -496,7 +493,7 @@ async def test_errorhandler_for_exception_swallows_exception(
496493
# In contrast to error handlers for a status code, error
497494
# handlers for exceptions can swallow the exception (this is
498495
# just how the Quart signal works)
499-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
496+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
500497
app = quart_app_factory()
501498
events = capture_events()
502499

@@ -520,7 +517,6 @@ async def test_tracing_success(sentry_init, capture_items):
520517
sentry_init(
521518
traces_sample_rate=1.0,
522519
integrations=[quart_sentry.QuartIntegration()],
523-
data_collection={},
524520
)
525521
app = quart_app_factory()
526522

@@ -557,7 +553,6 @@ async def test_tracing_error(sentry_init, capture_items):
557553
sentry_init(
558554
traces_sample_rate=1.0,
559555
integrations=[quart_sentry.QuartIntegration()],
560-
data_collection={},
561556
)
562557
app = quart_app_factory()
563558

@@ -586,7 +581,7 @@ async def error():
586581
async def test_class_based_views(sentry_init, capture_events):
587582
from quart.views import View
588583

589-
sentry_init(integrations=[quart_sentry.QuartIntegration()], data_collection={})
584+
sentry_init(integrations=[quart_sentry.QuartIntegration()])
590585
app = quart_app_factory()
591586
events = capture_events()
592587

@@ -615,7 +610,6 @@ async def test_span_origin(sentry_init, capture_items):
615610
sentry_init(
616611
integrations=[quart_sentry.QuartIntegration()],
617612
traces_sample_rate=1.0,
618-
data_collection={},
619613
)
620614
app = quart_app_factory()
621615
items = capture_items("span")
@@ -635,7 +629,6 @@ async def test_basic(sentry_init, capture_items):
635629
sentry_init(
636630
integrations=[quart_sentry.QuartIntegration()],
637631
traces_sample_rate=1.0,
638-
data_collection={},
639632
)
640633
items = capture_items("span")
641634

@@ -677,7 +670,6 @@ async def test_segment_name_and_source(
677670
sentry_init(
678671
integrations=[quart_sentry.QuartIntegration()],
679672
traces_sample_rate=1.0,
680-
data_collection={},
681673
)
682674
items = capture_items("span")
683675

@@ -702,7 +694,6 @@ async def test_with_error(sentry_init, capture_items):
702694
sentry_init(
703695
integrations=[quart_sentry.QuartIntegration()],
704696
traces_sample_rate=1.0,
705-
data_collection={},
706697
)
707698
items = capture_items("event", "span")
708699

@@ -1005,7 +996,6 @@ async def test_url_query_multi_and_blank_values(sentry_init, capture_items):
1005996
sentry_init(
1006997
integrations=[quart_sentry.QuartIntegration()],
1007998
traces_sample_rate=1.0,
1008-
data_collection={},
1009999
)
10101000
items = capture_items("span")
10111001

0 commit comments

Comments
 (0)