From 6922e24df515cf0ed4ab9842159bd9a395a32ee4 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 28 Sep 2026 11:56:09 +0200 Subject: [PATCH] chore(solidstart): Remove unused Vitest setup from e2e apps The SolidStart e2e apps only run Playwright. `vitest`, `@vitest/ui` and `vitest.config.ts` were leftovers from the Solid CLI template and kept old Vitest versions around in the repo. Co-Authored-By: Claude Opus 5.5 (1M context) --- .../test-applications/solidstart-2/README.md | 11 ----------- .../test-applications/solidstart-2/package.json | 4 +--- .../test-applications/solidstart-2/tsconfig.json | 2 +- .../test-applications/solidstart-2/vitest.config.ts | 10 ---------- .../solidstart-dynamic-import/README.md | 11 ----------- .../solidstart-dynamic-import/package.json | 3 +-- .../solidstart-dynamic-import/tsconfig.json | 2 +- .../solidstart-dynamic-import/vitest.config.ts | 10 ---------- .../test-applications/solidstart-spa/README.md | 11 ----------- .../test-applications/solidstart-spa/package.json | 3 +-- .../test-applications/solidstart-spa/tsconfig.json | 2 +- .../test-applications/solidstart-spa/vitest.config.ts | 10 ---------- .../test-applications/solidstart-static/README.md | 11 ----------- .../test-applications/solidstart-static/package.json | 3 +-- .../test-applications/solidstart-static/tsconfig.json | 2 +- .../solidstart-static/vitest.config.ts | 10 ---------- .../solidstart-top-level-import/README.md | 11 ----------- .../solidstart-top-level-import/package.json | 3 +-- .../solidstart-top-level-import/tsconfig.json | 2 +- .../solidstart-top-level-import/vitest.config.ts | 10 ---------- .../e2e-tests/test-applications/solidstart/README.md | 11 ----------- .../test-applications/solidstart/package.json | 3 +-- .../test-applications/solidstart/tsconfig.json | 2 +- .../test-applications/solidstart/vitest.config.ts | 10 ---------- 24 files changed, 12 insertions(+), 145 deletions(-) delete mode 100644 dev-packages/e2e-tests/test-applications/solidstart-2/vitest.config.ts delete mode 100644 dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/vitest.config.ts delete mode 100644 dev-packages/e2e-tests/test-applications/solidstart-spa/vitest.config.ts delete mode 100644 dev-packages/e2e-tests/test-applications/solidstart-static/vitest.config.ts delete mode 100644 dev-packages/e2e-tests/test-applications/solidstart-top-level-import/vitest.config.ts delete mode 100644 dev-packages/e2e-tests/test-applications/solidstart/vitest.config.ts diff --git a/dev-packages/e2e-tests/test-applications/solidstart-2/README.md b/dev-packages/e2e-tests/test-applications/solidstart-2/README.md index 9a141e9c2f0d..2b2846ee4ac8 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-2/README.md +++ b/dev-packages/e2e-tests/test-applications/solidstart-2/README.md @@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add it to the `devDependencies` in `package.json` and specify in your `app.config.js`. -## Testing - -Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some -helpful custom matchers. - -To run them, simply start: - -```sh -npm test -``` - ## This project was created with the [Solid CLI](https://solid-cli.netlify.app) diff --git a/dev-packages/e2e-tests/test-applications/solidstart-2/package.json b/dev-packages/e2e-tests/test-applications/solidstart-2/package.json index 58c2b2b37c00..9fd694db92d4 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-2/package.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-2/package.json @@ -25,13 +25,11 @@ "@solidjs/testing-library": "^0.8.10", "@testing-library/jest-dom": "^6.4.2", "@testing-library/user-event": "^14.5.2", - "@vitest/ui": "^1.5.0", "jsdom": "^24.0.0", "solid-js": "1.9.14", "typescript": "^5.4.5", "vite": "^8.1.5", - "vite-plugin-solid": "^2.11.6", - "vitest": "^1.5.0" + "vite-plugin-solid": "^2.11.6" }, "volta": { "extends": "../../package.json" diff --git a/dev-packages/e2e-tests/test-applications/solidstart-2/tsconfig.json b/dev-packages/e2e-tests/test-applications/solidstart-2/tsconfig.json index 3dcf7bfb7398..773b6011155d 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-2/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-2/tsconfig.json @@ -10,7 +10,7 @@ "allowJs": true, "strict": true, "noEmit": true, - "types": ["@solidjs/start/env", "vitest/globals", "@testing-library/jest-dom"], + "types": ["@solidjs/start/env", "@testing-library/jest-dom"], "isolatedModules": true, "paths": { "~/*": ["./src/*"] diff --git a/dev-packages/e2e-tests/test-applications/solidstart-2/vitest.config.ts b/dev-packages/e2e-tests/test-applications/solidstart-2/vitest.config.ts deleted file mode 100644 index 6c2b639dc300..000000000000 --- a/dev-packages/e2e-tests/test-applications/solidstart-2/vitest.config.ts +++ /dev/null @@ -1,10 +0,0 @@ -import solid from 'vite-plugin-solid'; -import { defineConfig } from 'vitest/config'; - -export default defineConfig({ - plugins: [solid()], - resolve: { - conditions: ['development', 'browser'], - }, - envPrefix: 'PUBLIC_', -}); diff --git a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/README.md b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/README.md index 9a141e9c2f0d..2b2846ee4ac8 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/README.md +++ b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/README.md @@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add it to the `devDependencies` in `package.json` and specify in your `app.config.js`. -## Testing - -Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some -helpful custom matchers. - -To run them, simply start: - -```sh -npm test -``` - ## This project was created with the [Solid CLI](https://solid-cli.netlify.app) diff --git a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/package.json b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/package.json index 9072e925225b..9d4519417b19 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/package.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/package.json @@ -28,8 +28,7 @@ "typescript": "^5.4.5", "vinxi": "^0.4.0", "vite": "^5.4.10", - "vite-plugin-solid": "^2.11.6", - "vitest": "^3.2.7" + "vite-plugin-solid": "^2.11.6" }, "volta": { "extends": "../../package.json" diff --git a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tsconfig.json b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tsconfig.json index 6f11292cc5d8..8619427a3226 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tsconfig.json @@ -10,7 +10,7 @@ "allowJs": true, "strict": true, "noEmit": true, - "types": ["vinxi/types/client", "vitest/globals", "@testing-library/jest-dom"], + "types": ["vinxi/types/client", "@testing-library/jest-dom"], "isolatedModules": true, "paths": { "~/*": ["./src/*"] diff --git a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/vitest.config.ts b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/vitest.config.ts deleted file mode 100644 index 6c2b639dc300..000000000000 --- a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/vitest.config.ts +++ /dev/null @@ -1,10 +0,0 @@ -import solid from 'vite-plugin-solid'; -import { defineConfig } from 'vitest/config'; - -export default defineConfig({ - plugins: [solid()], - resolve: { - conditions: ['development', 'browser'], - }, - envPrefix: 'PUBLIC_', -}); diff --git a/dev-packages/e2e-tests/test-applications/solidstart-spa/README.md b/dev-packages/e2e-tests/test-applications/solidstart-spa/README.md index 9a141e9c2f0d..2b2846ee4ac8 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-spa/README.md +++ b/dev-packages/e2e-tests/test-applications/solidstart-spa/README.md @@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add it to the `devDependencies` in `package.json` and specify in your `app.config.js`. -## Testing - -Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some -helpful custom matchers. - -To run them, simply start: - -```sh -npm test -``` - ## This project was created with the [Solid CLI](https://solid-cli.netlify.app) diff --git a/dev-packages/e2e-tests/test-applications/solidstart-spa/package.json b/dev-packages/e2e-tests/test-applications/solidstart-spa/package.json index 88f352108701..9636c7bb4600 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-spa/package.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-spa/package.json @@ -28,8 +28,7 @@ "typescript": "^5.4.5", "vinxi": "^0.4.0", "vite": "^5.4.11", - "vite-plugin-solid": "^2.11.6", - "vitest": "^3.2.7" + "vite-plugin-solid": "^2.11.6" }, "volta": { "extends": "../../package.json" diff --git a/dev-packages/e2e-tests/test-applications/solidstart-spa/tsconfig.json b/dev-packages/e2e-tests/test-applications/solidstart-spa/tsconfig.json index 6f11292cc5d8..8619427a3226 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-spa/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-spa/tsconfig.json @@ -10,7 +10,7 @@ "allowJs": true, "strict": true, "noEmit": true, - "types": ["vinxi/types/client", "vitest/globals", "@testing-library/jest-dom"], + "types": ["vinxi/types/client", "@testing-library/jest-dom"], "isolatedModules": true, "paths": { "~/*": ["./src/*"] diff --git a/dev-packages/e2e-tests/test-applications/solidstart-spa/vitest.config.ts b/dev-packages/e2e-tests/test-applications/solidstart-spa/vitest.config.ts deleted file mode 100644 index 6c2b639dc300..000000000000 --- a/dev-packages/e2e-tests/test-applications/solidstart-spa/vitest.config.ts +++ /dev/null @@ -1,10 +0,0 @@ -import solid from 'vite-plugin-solid'; -import { defineConfig } from 'vitest/config'; - -export default defineConfig({ - plugins: [solid()], - resolve: { - conditions: ['development', 'browser'], - }, - envPrefix: 'PUBLIC_', -}); diff --git a/dev-packages/e2e-tests/test-applications/solidstart-static/README.md b/dev-packages/e2e-tests/test-applications/solidstart-static/README.md index 9a141e9c2f0d..2b2846ee4ac8 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-static/README.md +++ b/dev-packages/e2e-tests/test-applications/solidstart-static/README.md @@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add it to the `devDependencies` in `package.json` and specify in your `app.config.js`. -## Testing - -Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some -helpful custom matchers. - -To run them, simply start: - -```sh -npm test -``` - ## This project was created with the [Solid CLI](https://solid-cli.netlify.app) diff --git a/dev-packages/e2e-tests/test-applications/solidstart-static/package.json b/dev-packages/e2e-tests/test-applications/solidstart-static/package.json index 1077b195acb6..e1d92d3bd733 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-static/package.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-static/package.json @@ -30,8 +30,7 @@ "typescript": "^5.4.5", "vinxi": "^0.4.0", "vite": "^5.4.11", - "vite-plugin-solid": "^2.11.6", - "vitest": "^3.2.7" + "vite-plugin-solid": "^2.11.6" }, "volta": { "node": "20.19.5", diff --git a/dev-packages/e2e-tests/test-applications/solidstart-static/tsconfig.json b/dev-packages/e2e-tests/test-applications/solidstart-static/tsconfig.json index 6f11292cc5d8..8619427a3226 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-static/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-static/tsconfig.json @@ -10,7 +10,7 @@ "allowJs": true, "strict": true, "noEmit": true, - "types": ["vinxi/types/client", "vitest/globals", "@testing-library/jest-dom"], + "types": ["vinxi/types/client", "@testing-library/jest-dom"], "isolatedModules": true, "paths": { "~/*": ["./src/*"] diff --git a/dev-packages/e2e-tests/test-applications/solidstart-static/vitest.config.ts b/dev-packages/e2e-tests/test-applications/solidstart-static/vitest.config.ts deleted file mode 100644 index 6c2b639dc300..000000000000 --- a/dev-packages/e2e-tests/test-applications/solidstart-static/vitest.config.ts +++ /dev/null @@ -1,10 +0,0 @@ -import solid from 'vite-plugin-solid'; -import { defineConfig } from 'vitest/config'; - -export default defineConfig({ - plugins: [solid()], - resolve: { - conditions: ['development', 'browser'], - }, - envPrefix: 'PUBLIC_', -}); diff --git a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/README.md b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/README.md index 9a141e9c2f0d..2b2846ee4ac8 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/README.md +++ b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/README.md @@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add it to the `devDependencies` in `package.json` and specify in your `app.config.js`. -## Testing - -Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some -helpful custom matchers. - -To run them, simply start: - -```sh -npm test -``` - ## This project was created with the [Solid CLI](https://solid-cli.netlify.app) diff --git a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/package.json b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/package.json index ad24ad3da154..fd1d1c82cbdc 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/package.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/package.json @@ -28,8 +28,7 @@ "typescript": "^5.4.5", "vinxi": "^0.4.0", "vite": "^5.4.11", - "vite-plugin-solid": "^2.11.6", - "vitest": "^3.2.7" + "vite-plugin-solid": "^2.11.6" }, "volta": { "extends": "../../package.json" diff --git a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tsconfig.json b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tsconfig.json index 6f11292cc5d8..8619427a3226 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tsconfig.json @@ -10,7 +10,7 @@ "allowJs": true, "strict": true, "noEmit": true, - "types": ["vinxi/types/client", "vitest/globals", "@testing-library/jest-dom"], + "types": ["vinxi/types/client", "@testing-library/jest-dom"], "isolatedModules": true, "paths": { "~/*": ["./src/*"] diff --git a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/vitest.config.ts b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/vitest.config.ts deleted file mode 100644 index 6c2b639dc300..000000000000 --- a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/vitest.config.ts +++ /dev/null @@ -1,10 +0,0 @@ -import solid from 'vite-plugin-solid'; -import { defineConfig } from 'vitest/config'; - -export default defineConfig({ - plugins: [solid()], - resolve: { - conditions: ['development', 'browser'], - }, - envPrefix: 'PUBLIC_', -}); diff --git a/dev-packages/e2e-tests/test-applications/solidstart/README.md b/dev-packages/e2e-tests/test-applications/solidstart/README.md index 9a141e9c2f0d..2b2846ee4ac8 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart/README.md +++ b/dev-packages/e2e-tests/test-applications/solidstart/README.md @@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add it to the `devDependencies` in `package.json` and specify in your `app.config.js`. -## Testing - -Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some -helpful custom matchers. - -To run them, simply start: - -```sh -npm test -``` - ## This project was created with the [Solid CLI](https://solid-cli.netlify.app) diff --git a/dev-packages/e2e-tests/test-applications/solidstart/package.json b/dev-packages/e2e-tests/test-applications/solidstart/package.json index ed907f5c5a47..a9c96734e0a2 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart/package.json +++ b/dev-packages/e2e-tests/test-applications/solidstart/package.json @@ -32,8 +32,7 @@ "typescript": "^5.4.5", "vinxi": "^0.4.0", "vite": "^5.4.11", - "vite-plugin-solid": "^2.11.6", - "vitest": "^3.2.7" + "vite-plugin-solid": "^2.11.6" }, "volta": { "node": "20.19.5", diff --git a/dev-packages/e2e-tests/test-applications/solidstart/tsconfig.json b/dev-packages/e2e-tests/test-applications/solidstart/tsconfig.json index 6f11292cc5d8..8619427a3226 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/solidstart/tsconfig.json @@ -10,7 +10,7 @@ "allowJs": true, "strict": true, "noEmit": true, - "types": ["vinxi/types/client", "vitest/globals", "@testing-library/jest-dom"], + "types": ["vinxi/types/client", "@testing-library/jest-dom"], "isolatedModules": true, "paths": { "~/*": ["./src/*"] diff --git a/dev-packages/e2e-tests/test-applications/solidstart/vitest.config.ts b/dev-packages/e2e-tests/test-applications/solidstart/vitest.config.ts deleted file mode 100644 index 6c2b639dc300..000000000000 --- a/dev-packages/e2e-tests/test-applications/solidstart/vitest.config.ts +++ /dev/null @@ -1,10 +0,0 @@ -import solid from 'vite-plugin-solid'; -import { defineConfig } from 'vitest/config'; - -export default defineConfig({ - plugins: [solid()], - resolve: { - conditions: ['development', 'browser'], - }, - envPrefix: 'PUBLIC_', -});