Repository navigation
Commit d8752db
feat(ember): Give component definition lookups their own span op
Ember spans that resolve a component definition were using the `function`
op, which infers a span description of "Function execution" and loses the
component name. They now use `ui.resolve`, a new op proposed in
getsentry/sentry-conventions#633. The op is hard-coded with a TODO until
that lands and we can import the const.
Route hook spans keep the route as `sentry.description` and are named after
the hook when span streaming is on, so the name matches `code.function.name`
(the `function` op's name template) in both trace lifecycles.
Also converts the `ember-classic` E2E app to span streaming and turns on
`enableComponentDefinitions` there, so `ui.resolve` gets covered. That flag
was off in every app, so the code path had never run in CI. `ember-embroider`
and `ember-vite` still cover the static lifecycle.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 1edada7 commit d8752db
11 files changed
Lines changed: 417 additions & 317 deletions
File tree
- dev-packages/e2e-tests/test-applications
- ember-classic
- app
- instance-initializers
- tests
- ember-embroider/tests
- ember-strict-resolver/tests
- packages/ember
- src/utils
- tests
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
35 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
42 | | - | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
0 commit comments