Skip to content

Commit c16c489

Browse files
Lms24claude
andcommitted
chore(deps): Remove remaining Vitest 3 dependencies
Bump deno-integration-tests and the debug-id-sourcemaps e2e app to Vitest 4. Vitest 4 no longer accepts test options as the third argument, so pass them second. The SolidStart e2e apps never run Vitest (they only run Playwright); `vitest`, `@vitest/ui` and `vitest.config.ts` were template leftovers. Remove them instead of bumping, since Vitest 4 requires Vite >= 6 and most of these apps test Vite 5 builds. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent ab87290 commit c16c489

27 files changed

Lines changed: 54 additions & 191 deletions

File tree

‎dev-packages/deno-integration-tests/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
},
2424
"devDependencies": {
2525
"@sentry-internal/node-integration-tests": "11.0.0",
26-
"vitest": "^3.2.7"
26+
"vitest": "^4.1.11"
2727
},
2828
"volta": {
2929
"extends": "../../package.json"

‎dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
},
1515
"devDependencies": {
1616
"rollup": "^4.35.0",
17-
"vitest": "^3.2.7",
17+
"vitest": "^4.1.11",
1818
"@sentry/rollup-plugin": "^5.3.0"
1919
},
2020
"volta": {

‎dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/tests/server.test.ts‎

Lines changed: 40 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -28,56 +28,52 @@ function splitFrameContext(frame: SerializedFrame): Record<string, unknown> {
2828
};
2929
}
3030

31-
test(
32-
'Find symbolicated event on sentry',
33-
async ({ expect }) => {
34-
const eventId = childProcess.execSync(`node ${path.join(__dirname, '..', 'dist', 'app.js')}`, {
35-
encoding: 'utf-8',
36-
});
37-
38-
console.log(`Polling for error eventId: ${eventId}`);
31+
test('Find symbolicated event on sentry', { timeout: EVENT_POLLING_TIMEOUT }, async ({ expect }) => {
32+
const eventId = childProcess.execSync(`node ${path.join(__dirname, '..', 'dist', 'app.js')}`, {
33+
encoding: 'utf-8',
34+
});
3935

40-
let timedOut = false;
41-
setTimeout(() => {
42-
timedOut = true;
43-
}, EVENT_POLLING_TIMEOUT);
36+
console.log(`Polling for error eventId: ${eventId}`);
4437

45-
while (!timedOut) {
46-
await new Promise(resolve => setTimeout(resolve, 2000)); // poll every two seconds
47-
const response = await fetch(`https://sentry.io/api/0/organizations/${sentryTestOrgSlug}/eventids/${eventId}/`, {
48-
headers: { Authorization: `Bearer ${authToken}` },
49-
});
38+
let timedOut = false;
39+
setTimeout(() => {
40+
timedOut = true;
41+
}, EVENT_POLLING_TIMEOUT);
5042

51-
// This is org scoped, so the auth token needs `org:read` on top of the project scopes.
52-
// That never resolves by waiting, so fail loudly rather than timing out.
53-
if (response.status === 401 || response.status === 403) {
54-
throw new Error(
55-
`Event lookup was rejected with ${response.status}: ${await response.text()}. ` +
56-
'E2E_TEST_AUTH_TOKEN needs the `org:read` scope.',
57-
);
58-
}
43+
while (!timedOut) {
44+
await new Promise(resolve => setTimeout(resolve, 2000)); // poll every two seconds
45+
const response = await fetch(`https://sentry.io/api/0/organizations/${sentryTestOrgSlug}/eventids/${eventId}/`, {
46+
headers: { Authorization: `Bearer ${authToken}` },
47+
});
5948

60-
// A 404 means the event has not landed yet and a 429 is the shared test org being rate limited.
61-
// Both clear up by polling again.
62-
if (!response.ok) {
63-
expect([404, 429]).toContain(response.status);
64-
continue;
65-
}
49+
// This is org scoped, so the auth token needs `org:read` on top of the project scopes.
50+
// That never resolves by waiting, so fail loudly rather than timing out.
51+
if (response.status === 401 || response.status === 403) {
52+
throw new Error(
53+
`Event lookup was rejected with ${response.status}: ${await response.text()}. ` +
54+
'E2E_TEST_AUTH_TOKEN needs the `org:read` scope.',
55+
);
56+
}
6657

67-
const { event } = await response.json();
68-
const exception = event.entries.find((entry: { type: string }) => entry.type === 'exception');
69-
const frames: SerializedFrame[] = exception.data.values[0].stacktrace.frames;
70-
const topFrame = frames[frames.length - 1];
58+
// A 404 means the event has not landed yet and a 429 is the shared test org being rate limited.
59+
// Both clear up by polling again.
60+
if (!response.ok) {
61+
expect([404, 429]).toContain(response.status);
62+
continue;
63+
}
7164

72-
if (topFrame === undefined) {
73-
throw new Error('Symbolicated event has no stack frames.');
74-
}
65+
const { event } = await response.json();
66+
const exception = event.entries.find((entry: { type: string }) => entry.type === 'exception');
67+
const frames: SerializedFrame[] = exception.data.values[0].stacktrace.frames;
68+
const topFrame = frames[frames.length - 1];
7569

76-
expect(splitFrameContext(topFrame)).toMatchSnapshot();
77-
return;
70+
if (topFrame === undefined) {
71+
throw new Error('Symbolicated event has no stack frames.');
7872
}
7973

80-
throw new Error('Test timed out');
81-
},
82-
{ timeout: EVENT_POLLING_TIMEOUT },
83-
);
74+
expect(splitFrameContext(topFrame)).toMatchSnapshot();
75+
return;
76+
}
77+
78+
throw new Error('Test timed out');
79+
});

‎dev-packages/e2e-tests/test-applications/solidstart-2/README.md‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment
3131
By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add
3232
it to the `devDependencies` in `package.json` and specify in your `app.config.js`.
3333

34-
## Testing
35-
36-
Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some
37-
helpful custom matchers.
38-
39-
To run them, simply start:
40-
41-
```sh
42-
npm test
43-
```
44-
4534
## This project was created with the [Solid CLI](https://solid-cli.netlify.app)

‎dev-packages/e2e-tests/test-applications/solidstart-2/package.json‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,11 @@
2525
"@solidjs/testing-library": "^0.8.10",
2626
"@testing-library/jest-dom": "^6.4.2",
2727
"@testing-library/user-event": "^14.5.2",
28-
"@vitest/ui": "^1.5.0",
2928
"jsdom": "^24.0.0",
3029
"solid-js": "1.9.14",
3130
"typescript": "^5.4.5",
3231
"vite": "^8.1.5",
33-
"vite-plugin-solid": "^2.11.6",
34-
"vitest": "^1.5.0"
32+
"vite-plugin-solid": "^2.11.6"
3533
},
3634
"volta": {
3735
"extends": "../../package.json",

‎dev-packages/e2e-tests/test-applications/solidstart-2/tsconfig.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"allowJs": true,
1111
"strict": true,
1212
"noEmit": true,
13-
"types": ["@solidjs/start/env", "vitest/globals", "@testing-library/jest-dom"],
13+
"types": ["@solidjs/start/env", "@testing-library/jest-dom"],
1414
"isolatedModules": true,
1515
"paths": {
1616
"~/*": ["./src/*"]

‎dev-packages/e2e-tests/test-applications/solidstart-2/vitest.config.ts‎

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/README.md‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,4 @@ Solid apps are built with _presets_, which optimise your project for deployment
3131
By default, `npm run build` will generate a Node app that you can run with `npm start`. To use a different preset, add
3232
it to the `devDependencies` in `package.json` and specify in your `app.config.js`.
3333

34-
## Testing
35-
36-
Tests are written with `vitest`, `@solidjs/testing-library` and `@testing-library/jest-dom` to extend expect with some
37-
helpful custom matchers.
38-
39-
To run them, simply start:
40-
41-
```sh
42-
npm test
43-
```
44-
4534
## This project was created with the [Solid CLI](https://solid-cli.netlify.app)

‎dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
"typescript": "^5.4.5",
2929
"vinxi": "^0.4.0",
3030
"vite": "^5.4.10",
31-
"vite-plugin-solid": "^2.11.6",
32-
"vitest": "^3.2.7"
31+
"vite-plugin-solid": "^2.11.6"
3332
},
3433
"volta": {
3534
"extends": "../../package.json"

‎dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tsconfig.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"allowJs": true,
1111
"strict": true,
1212
"noEmit": true,
13-
"types": ["vinxi/types/client", "vitest/globals", "@testing-library/jest-dom"],
13+
"types": ["vinxi/types/client", "@testing-library/jest-dom"],
1414
"isolatedModules": true,
1515
"paths": {
1616
"~/*": ["./src/*"]

0 commit comments

Comments
 (0)