Skip to content

Commit 2aa229d

Browse files
nicohrubeccodex
andcommitted
ci: focus experiment on test parallelism
Increase browser Playwright CI workers to six. Remove Node timing reports and restore the original bundle build, retaining three shards for every Node integration configuration. Co-Authored-By: GPT-6 <codex@openai.com>
1 parent 8690594 commit 2aa229d

4 files changed

Lines changed: 12 additions & 28 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -842,17 +842,6 @@ jobs:
842842
working-directory: dev-packages/node-integration-tests
843843
run: yarn test --shard=${{ matrix.shard }}/3
844844

845-
- name: Upload test timing report
846-
uses: actions/upload-artifact@v7
847-
if: ${{ !cancelled() }}
848-
with:
849-
name:
850-
node-integration-timings-node-${{ matrix.node }}-ts-${{ matrix.typescript || 'default' }}-shard-${{
851-
matrix.shard }}
852-
path: dev-packages/node-integration-tests/vitest.junit.xml
853-
retention-days: 7
854-
if-no-files-found: warn
855-
856845
job_cloudflare_integration_tests:
857846
name: Cloudflare Integration Tests
858847
needs: [job_get_metadata, job_build]

‎dev-packages/browser-integration-tests/playwright.browser.config.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import CorePlaywrightConfig from './playwright.config';
33

44
const config: PlaywrightTestConfig = {
55
...CorePlaywrightConfig,
6+
workers: process.env.CI ? 6 : CorePlaywrightConfig.workers,
67
testDir: './suites',
78
};
89

‎dev-packages/node-integration-tests/vite.config.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export default defineConfig({
2525
reporters: process.env.DEBUG
2626
? [['default', { summary: false }]]
2727
: process.env.GITHUB_ACTIONS
28-
? ['dot', 'github-actions', ['junit', { classnameTemplate: '{filepath}' }]]
28+
? ['dot', 'github-actions']
2929
: ['verbose'],
3030
},
3131
});

‎dev-packages/rollup-utils/bundleHelpers.mjs‎

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,9 @@ export function makeBaseBundleConfig(options) {
142142
* @param baseConfig The rollup config shared by the entire package
143143
* @returns An array of versions of that config
144144
*/
145-
export function makeBundleConfigVariants(baseConfig) {
145+
export function makeBundleConfigVariants(baseConfig, options = {}) {
146+
const { variants = BUNDLE_VARIANTS } = options;
147+
146148
const includeDebuggingPlugin = makeIsDebugBuildPlugin(true);
147149
const stripDebuggingPlugin = makeIsDebugBuildPlugin(false);
148150
const terserPlugin = makeTerserPlugin();
@@ -172,22 +174,14 @@ export function makeBundleConfigVariants(baseConfig) {
172174
},
173175
};
174176

175-
const [debug, production, minifiedDebug] = BUNDLE_VARIANTS.map(variant =>
176-
deepMerge(baseConfig, variantSpecificConfigMap[variant], {
177+
return variants.map(variant => {
178+
if (!BUNDLE_VARIANTS.includes(variant)) {
179+
throw new Error(`Unknown bundle variant requested: ${variant}`);
180+
}
181+
return deepMerge(baseConfig, variantSpecificConfigMap[variant], {
177182
// Merge the plugin arrays and make sure the end result is in the correct order. Everything else can use the
178183
// default merge strategy.
179184
customMerge: key => (key === 'plugins' ? mergePlugins : undefined),
180-
}),
181-
);
182-
183-
const isOutputPlugin = plugin => ['terser', 'license'].includes(plugin.name);
184-
185-
debug.output = [debug, minifiedDebug].map(config => ({
186-
...config.output,
187-
plugins: config.plugins.filter(isOutputPlugin),
188-
}));
189-
190-
debug.plugins = debug.plugins.filter(plugin => !isOutputPlugin(plugin));
191-
192-
return [debug, production];
185+
});
186+
});
193187
}

0 commit comments

Comments
 (0)