ref(server-utils): Import messaging.destination_kind from conventions

`@sentry/conventions` ships `MESSAGING_DESTINATION_KIND` since 0.19.0, so the local key constant is no
longer needed. The `topic` value stays local, since conventions only covers attribute keys.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: chargome

packages/server-utils/src/integrations/aws-sdk/constants.ts

@@ -1,8 +1,7 @@
 /**
  * AWS-specific span constants used by the aws-sdk channel integration that are NOT covered by
  * `@sentry/conventions/attributes` (attribute names that exist there are imported from there
- * directly). These are either Sentry-specific (the span origin), attribute *values* (not keys), or
- * obsolete OTel conventions with no `@sentry/conventions` export.
+ * directly). These are either Sentry-specific (the span origin) or attribute *values* (not keys).
  */
 
 /** The span origin every aws-sdk channel span carries. */
@@ -11,10 +10,7 @@ export const AWS_SDK_ORIGIN = 'auto.aws.aws_sdk';
 /** DynamoDB `db.system.name` value (an attribute value, not a key, so not covered by conventions). */
 export const DB_SYSTEM_VALUE_DYNAMODB = 'dynamodb';
 
-// Messaging (obsolete OTel convention with no `@sentry/conventions` export, kept for parity)
-// TODO(v11): import from `@sentry/conventions` once a release including it ships (added in
-// getsentry/sentry-conventions#509), and drop this local constant.
-export const ATTR_MESSAGING_DESTINATION_KIND = 'messaging.destination_kind';
+/** SNS `messaging.destination_kind` value (an attribute value, not a key, so not covered by conventions). */
 export const MESSAGING_DESTINATION_KIND_VALUE_TOPIC = 'topic';
 
 // Bedrock (gen_ai) attribute values (not keys, so not covered by conventions)

packages/server-utils/src/integrations/aws-sdk/services/sns.ts

@@ -3,13 +3,14 @@ import { getClient, getTraceData, hasSpanStreamingEnabled } from '@sentry/core';
 import {
   AWS_SNS_TOPIC_ARN as ATTR_AWS_SNS_TOPIC_ARN,
   MESSAGING_DESTINATION as ATTR_MESSAGING_DESTINATION,
+  MESSAGING_DESTINATION_KIND as ATTR_MESSAGING_DESTINATION_KIND,
   MESSAGING_DESTINATION_NAME,
   MESSAGING_OPERATION_TYPE,
   MESSAGING_SYSTEM,
   SENTRY_KIND,
 } from '@sentry/conventions/attributes';
 import { QUEUE_PUBLISH } from '@sentry/conventions/op';
-import { ATTR_MESSAGING_DESTINATION_KIND, MESSAGING_DESTINATION_KIND_VALUE_TOPIC } from '../constants';
+import { MESSAGING_DESTINATION_KIND_VALUE_TOPIC } from '../constants';
 import type { NormalizedRequest, NormalizedResponse } from '../types';
 import { injectPropagationContext } from './MessageAttributes';
 import type { RequestMetadata, ServiceExtension } from './ServiceExtension';
@@ -43,6 +44,7 @@ export class SnsServiceExtension implements ServiceExtension {
       spanOp = QUEUE_PUBLISH;
       spanAttributes[SENTRY_KIND] = 'producer';
 
+      // oxlint-disable-next-line typescript/no-deprecated -- old-semconv messaging.destination_kind, matched to the OTel aws-sdk integration
       spanAttributes[ATTR_MESSAGING_DESTINATION_KIND] = MESSAGING_DESTINATION_KIND_VALUE_TOPIC;
       const { TopicArn, TargetArn, PhoneNumber } = request.commandInput;
       const destinationName = extractDestinationName(TopicArn, TargetArn, PhoneNumber);