From e7d5546fc7291d55da7741b9bf4f2ad44c88da55 Mon Sep 17 00:00:00 2001 From: Vladimir Chernyshev Date: Tue, 18 Aug 2026 11:04:21 -0700 Subject: [PATCH] fix: pass BASE_TEST_ENV to the coverage target The coverage target hand-rolled its environment with only GOPROXY and GOPRIVATE, so TEST_TAGS was never exported. shell/test.sh defaults it to empty, meaning make coverage ran untagged while make test and test-e2e did not. Untagged builds exclude or_test-gated files, so any package whose tests reach a tagged dependency fails to compile and is dropped from the coverage run, under-reporting coverage for every Go service. --- root/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/root/Makefile b/root/Makefile index 54e6825d..c41e5fa9 100644 --- a/root/Makefile +++ b/root/Makefile @@ -130,8 +130,8 @@ test-e2e:: pre-test ## coverage: generate code coverage .PHONY: coverage coverage:: pre-coverage - WITH_COVERAGE=true GOPROXY=$(GOPROXY) GOPRIVATE=$(GOPRIVATE) ./scripts/shell-wrapper.sh test.sh - go tool cover --html=/tmp/coverage.out + $(BASE_TEST_ENV) WITH_COVERAGE=true ./scripts/shell-wrapper.sh test.sh + go tool cover --html=/tmp/coverage.out .PHONY: e2e e2e:: pre-e2e