Handle exceeding the limit gracefully (#2067)

* feat: Handle exceeding the limit gracefully

Will now return a 400 to the user with info what the limit was that
caused the error.

* fix: fix test for evaluate_limit

---------

Co-authored-by: Matt Aschmann <maschmann@igsftr116lwmas2.gs.doi.net>

Author: mattaschmann

pygeoapi/api/__init__.py

@@ -1670,7 +1670,7 @@ def evaluate_limit(requested: Union[None, int], server_limits: dict,
     if requested2 <= 0:
         raise ValueError('limit value should be strictly positive')
     elif requested2 > max_ and on_exceed == 'error':
-        raise RuntimeError('Limit exceeded; throwing errror')
+        raise ValueError(f'Limit of {max_} exceeded')
     else:
         LOGGER.debug('limit requested')
         return min(requested2, max_)

tests/api/test_api.py

@@ -879,7 +879,7 @@ def test_evaluate_limit():
     collection = {}
     server = {'default_items': 2, 'max_items': 3, 'on_exceed': 'error'}
 
-    with pytest.raises(RuntimeError):
+    with pytest.raises(ValueError):
         assert evaluate_limit('40', server, collection) == 40
 
     collection = {'default_items': 10}