PB-1383: update libs and adapt to newer linter version

Author: pakb

package.json

@@ -56,7 +56,7 @@
         ],
         "patchedDependencies": {
             "@geoblocks/mapfishprint@0.2.22": "patches/@geoblocks__mapfishprint@0.2.22.patch",
-            "ol@10.7.0": "patches/ol@10.7.0.patch"
+            "ol@10.8.0": "patches/ol@10.8.0.patch"
         },
         "ignoredBuiltDependencies": [
             "core-js",

packages/api/src/topics.ts

@@ -149,7 +149,7 @@ async function loadTopicTreeForTopic(
             titleColor: LogPreDefinedColor.Amber,
             messages: [errorMessage, error],
         })
-        throw new Error(errorMessage)
+        throw new Error(errorMessage, { cause: error})
     }
 }
 
@@ -169,7 +169,7 @@ async function loadTopics(): Promise<ServicesResponse> {
             titleColor: LogPreDefinedColor.Amber,
             messages: [errorMessage, error],
         })
-        throw new Error(errorMessage)
+        throw new Error(errorMessage, { cause: error})
     }
 }
 

packages/config/eslint/index.ts

@@ -34,6 +34,7 @@ const commonTsAndJsRules: PartialRules = {
     'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
     // has some issue (with typescript-eslint for instance), so we disable it (TS does already a good job at detecting unresolved imports)
     'import/no-unresolved': 'off',
+    'no-useless-assignment': 'off',
 }
 
 const noUnusedVarsRules: PartialRules = {

packages/mapviewer/src/modules/drawing/components/ShareWarningPopup.vue

@@ -65,11 +65,9 @@ updateAdminShareUrl().catch((error: Error) =>
 )
 
 let adminTimeout: ReturnType<typeof setTimeout> | undefined
-let fileTimeout: ReturnType<typeof setTimeout> | undefined
 
 onUnmounted(() => {
     clearTimeout(adminTimeout)
-    clearTimeout(fileTimeout)
 })
 
 function onAccept() {
@@ -92,9 +90,9 @@ async function updateShareUrl() {
     if (fileUrl.value) {
         try {
             shareUrl.value = await shortLinkAPI.createShortLink({
-                url: fileUrl.value, 
+                url: fileUrl.value,
                 withCrosshair: !!shareUrl.value,
-                staging: ENVIRONMENT
+                staging: ENVIRONMENT,
             })
         } catch (_) {
             // Fallback to normal url
@@ -107,7 +105,7 @@ async function updateAdminShareUrl() {
         try {
             adminShareUrl.value = await shortLinkAPI.createShortLink({
                 url: adminUrl.value,
-                staging: ENVIRONMENT
+                staging: ENVIRONMENT,
             })
         } catch (_) {
             // Fallback to normal url

packages/mapviewer/src/modules/map/components/openlayers/OpenLayersScale.vue

@@ -53,7 +53,7 @@ onBeforeUnmount(() => olMap.removeControl(scaleLine))
         v-show="showScaleLine"
         ref="scaleLineElement"
         class="scale-line-container"
-        :class="withRelativeSize"
+        :class="{ 'with-relative-size': withRelativeSize }"
         data-cy="scaleline"
     />
 </template>

packages/mapviewer/src/store/plugins/storeSync/urlToStore.plugin.ts

@@ -232,6 +232,8 @@ let hasBeenInitialized: boolean = false
 const urlToStorePlugin: PiniaPlugin = (context: PiniaPluginContext) => {
     const { store } = context
 
+    queryParamsStoredAtStartup = store.router.currentRoute.value.query
+
     store.$onAction(({ after }) => {
         const appStore = useAppStore()
         if (appStore.isParsingUrl && !hasBeenInitialized) {

packages/mapviewer/tests/cypress/tests-e2e/reportProblem.cy.ts

@@ -244,8 +244,6 @@ describe('Testing the report problem form', () => {
     })
 
     it('reports a problem with drawing attachment', () => {
-        let kmlBody: string | FormData | undefined
-
         interceptPostKml()
         cy.goToMapView()
         interceptFeedback(true)
@@ -392,7 +390,6 @@ describe('Testing the report problem form', () => {
 
         cy.wait('@post-kml')
 
-        console.log('KML Body:', kmlBody)
         cy.get('@reportForm').should('exist')
         cy.get('[data-cy="drawing-header-title"]').should('not.exist')
         cy.get('@textArea').should('have.value', text)

patches/ol@10.7.0.patch patches/ol@10.8.0.patchpatches/ol@10.7.0.patch renamed to patches/ol@10.8.0.patch

@@ -1,8 +1,8 @@
 diff --git a/style/Icon.js b/style/Icon.js
-index bfd9abd6cb1cee531f4feb651149d6b406606569..26fcfe2b58738a97bf6619c621f491571bd76f9b 100644
+index 50d5aa80b0331adc0b6021e53e921026cb483999..b7d1774f664aac3153c49a0e531f41ad6d4725e9 100644
 --- a/style/Icon.js
 +++ b/style/Icon.js
-@@ -380,8 +380,8 @@ class Icon extends ImageStyle {
+@@ -391,8 +391,8 @@ class Icon extends ImageStyle {
      // anchor is scaled by renderer but displacement should not be scaled
      // so divide by scale here
      return [