Skip to content

Commit 4ed36f0

Browse files
committed
PB-117: Use github generated release notes instead of release-note-drafter
The release note drafter had an issue with our workflow with hotfix on master branch, which is not the case with the native github generated release notes feature.
1 parent b4c86e1 commit 4ed36f0

4 files changed

Lines changed: 15 additions & 89 deletions

File tree

.github/release-drafter-config.yml

Lines changed: 0 additions & 29 deletions
This file was deleted.

.github/release.yml

Lines changed: 0 additions & 35 deletions
This file was deleted.

.github/workflows/milestone-release.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,13 @@ jobs:
4646
# Get the next milestone branch name, the jq command will return the second
4747
# branch name in the list of branches matching the pattern develop-YYYY-MM-DD
4848
# The first branch is the current branch, the second one is the next milestone
49-
# branch. If there is no next milestone branch, then jq will return null.
49+
# branch. If t- name: Create new release with auto generated release note
50+
# Do not generate release for beta release tagged on develop branch.
51+
if: ${{ github.ref == 'refs/heads/master' }}
52+
env:
53+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
54+
run: |
55+
gh release create "${{ steps.tagging.outputs.new_tag }}" --generate-notes --repo "${{ github.repository }}"here is no next milestone branch, then jq will return null.
5056
next_milestone_branch=$( \
5157
gh api \
5258
-H "Accept: application/vnd.github+json" \
@@ -145,18 +151,13 @@ jobs:
145151
milestone_pattern: '\d{4}-\d{2}-\d{2}'
146152

147153
# Drafts your next Release notes as Pull Requests are merged into "master"
148-
- name: Create Release with Release Notes
149-
uses: release-drafter/release-drafter@v6
150-
if: ${{ github.base_ref == 'master' }}
151-
with:
152-
config-name: release-drafter-config.yml
153-
disable-autolabeler: true
154-
publish: true
155-
tag: ${{ steps.tagging-release.outputs.new_tag }}
156-
version: ${{ steps.tagging-release.outputs.new_tag }}
157-
name: ${{ steps.tagging-release.outputs.new_tag }}
154+
- name: Create new release with auto generated release note
155+
# Do not generate release for beta release tagged on develop branch.
156+
if: ${{ github.ref == 'refs/heads/master' }}
158157
env:
159158
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
159+
run: |
160+
gh release create "${{ steps.tagging-release.outputs.new_tag }}" --generate-notes --repo "${{ github.repository }}"
160161
161162
# Close the milestone if needed
162163
- name: Get milestone name from tag

.github/workflows/semver-release.yml

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,21 +43,10 @@ jobs:
4343
TAG_CONTEXT: repo
4444
VERBOSE: true
4545

46-
- name: Set `New Release` PR title if needed
47-
if: ${{ github.base_ref == 'refs/heads/master' }}
48-
run: echo "${{ steps.tagging.outputs.new_tag }}"
49-
50-
# Drafts your next Release notes as Pull Requests are merged into "master"
51-
- name: Create Release with Release Notes
52-
uses: release-drafter/release-drafter@v6
46+
- name: Create new release with auto generated release note
5347
# Do not generate release for beta release tagged on develop branch.
5448
if: ${{ github.ref == 'refs/heads/master' }}
55-
with:
56-
config-name: release-drafter-config.yml
57-
disable-autolabeler: true
58-
publish: true
59-
tag: ${{ steps.tagging.outputs.new_tag }}
60-
version: ${{ steps.tagging.outputs.new_tag }}
61-
name: ${{ steps.tagging.outputs.new_tag }}
6249
env:
6350
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
51+
run: |
52+
gh release create "${{ steps.tagging.outputs.new_tag }}" --generate-notes --repo "${{ github.repository }}"

0 commit comments

Comments
 (0)