Skip to content

Commit 6116cea

Browse files
committed
Correct missing control flow
1 parent 77f3f80 commit 6116cea

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/main/java/org/gaul/httpbin/HttpBinHandler.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public void handle(String target, Request baseRequest,
8888
Utils.copy(is, Utils.NULL_OUTPUT_STREAM);
8989
redirectTo(servletResponse, request.getParameter("url"));
9090
baseRequest.setHandled(true);
91+
return;
9192
} else if (uri.startsWith("/redirect/")) {
9293
Utils.copy(is, Utils.NULL_OUTPUT_STREAM);
9394

@@ -100,6 +101,7 @@ public void handle(String target, Request baseRequest,
100101
}
101102

102103
baseRequest.setHandled(true);
104+
return;
103105
} else if (method.equals("GET") &&
104106
uri.equals("/response-headers")) {
105107
Utils.copy(is, Utils.NULL_OUTPUT_STREAM);
@@ -127,6 +129,7 @@ public void handle(String target, Request baseRequest,
127129

128130
respondJSON(servletResponse, os, response);
129131
baseRequest.setHandled(true);
132+
return;
130133
} else if (uri.startsWith("/cookies/set/")) {
131134
Utils.copy(is, Utils.NULL_OUTPUT_STREAM);
132135

@@ -140,6 +143,7 @@ public void handle(String target, Request baseRequest,
140143
servletResponse.setStatus(
141144
HttpServletResponse.SC_MOVED_TEMPORARILY);
142145
baseRequest.setHandled(true);
146+
return;
143147
} else if (uri.startsWith("/basic-auth")) {
144148
Utils.copy(is, Utils.NULL_OUTPUT_STREAM);
145149

@@ -148,6 +152,7 @@ public void handle(String target, Request baseRequest,
148152
"Basic realm=\"Fake Realm\"");
149153
servletResponse.setStatus(HttpServletResponse.SC_UNAUTHORIZED);
150154
baseRequest.setHandled(true);
155+
return;
151156
} else if (uri.equals("/anything")) {
152157
servletResponse.setStatus(HttpServletResponse.SC_OK);
153158
baseRequest.setHandled(true);
@@ -174,6 +179,7 @@ public void handle(String target, Request baseRequest,
174179
response.put("data", data.toString("UTF-8"));
175180
respondJSON(servletResponse, os, response);
176181
baseRequest.setHandled(true);
182+
return;
177183
}
178184
servletResponse.setStatus(501);
179185
baseRequest.setHandled(true);

0 commit comments

Comments
 (0)