Skip to content

Commit 69c82aa

Browse files
authored
Fix pylint warnings (#459)
1 parent f93a87f commit 69c82aa

2 files changed

Lines changed: 8 additions & 13 deletions

File tree

src/wled/models.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,7 @@ def from_dict(data: dict[str, Any]) -> Info:
290290
Returns:
291291
A info object.
292292
"""
293-
websocket = data.get("ws")
294-
if websocket == -1:
293+
if (websocket := data.get("ws")) == -1:
295294
websocket = None
296295

297296
return Info(

src/wled/wled.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
import asyncio
55
import json
66
import socket
7+
from collections.abc import Callable
78
from dataclasses import dataclass
8-
from typing import Any, Callable
9+
from typing import Any
910

1011
import aiohttp
1112
import async_timeout
@@ -225,8 +226,7 @@ async def update(self, full_update: bool = False) -> Device:
225226
WLEDEmptyResponseError: The WLED device returned an empty response.
226227
"""
227228
if self._device is None or full_update:
228-
data = await self.request("/json")
229-
if not data:
229+
if not (data := await self.request("/json")):
230230
raise WLEDEmptyResponseError(
231231
f"WLED device at {self.host} returned an empty API"
232232
" response on full update"
@@ -260,8 +260,7 @@ async def update(self, full_update: bool = False) -> Device:
260260
return self._device
261261

262262
if self._supports_presets:
263-
presets = await self.request("/presets.json")
264-
if not presets:
263+
if not (presets := await self.request("/presets.json")):
265264
raise WLEDEmptyResponseError(
266265
f"WLED device at {self.host} returned an empty API"
267266
" response on presets update"
@@ -270,24 +269,21 @@ async def update(self, full_update: bool = False) -> Device:
270269

271270
# Handle legacy state and update in separate requests
272271
if not self._supports_si_request:
273-
info = await self.request("/json/info")
274-
if not info:
272+
if not (info := await self.request("/json/info")):
275273
raise WLEDEmptyResponseError(
276274
f"WLED device at {self.host} returned an empty API"
277275
" response on info update"
278276
)
279277

280-
state = await self.request("/json/state")
281-
if not state:
278+
if not (state := await self.request("/json/state")):
282279
raise WLEDEmptyResponseError(
283280
f"WLED device {self.host} returned an empty API"
284281
" response on state update"
285282
)
286283
self._device.update_from_dict({"info": info, "state": state})
287284
return self._device
288285

289-
state_info = await self.request("/json/si")
290-
if not state_info:
286+
if not (state_info := await self.request("/json/si")):
291287
raise WLEDEmptyResponseError(
292288
f"WLED device at {self.host} returned an empty API"
293289
" response on state & info update"

0 commit comments

Comments
 (0)