From 1f7299534becc44cc4306718f667cb47232a7111 Mon Sep 17 00:00:00 2001 From: jesswrd Date: Fri, 25 Sep 2026 22:40:08 +0000 Subject: [PATCH 1/3] [camera_android_camerax] Move misplaced Javadoc above annotations The Javadoc for DeviceOrientationManager.createOrientationEventListener was placed after its annotations, so it was not attached to the method. javac 23+ reports this with the new dangling-doc-comments lint, which breaks the example app's -Xlint:all -Werror build on JDK 25. --- .../io/flutter/plugins/camerax/DeviceOrientationManager.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/DeviceOrientationManager.java b/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/DeviceOrientationManager.java index 83d8573cf2a8..a7b8616caf0c 100644 --- a/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/DeviceOrientationManager.java +++ b/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/DeviceOrientationManager.java @@ -60,14 +60,14 @@ public void start() { orientationEventListener.enable(); } - @VisibleForTesting - @NonNull /** * Creates an {@link OrientationEventListener} that will call the callback method of the {@link * DeviceOrientationManagerProxyApi} whenever it is notified of a new device orientation and this * {@code DeviceOrientationManager} instance determines that the orientation of the device {@link * Configuration} has changed. */ + @VisibleForTesting + @NonNull protected OrientationEventListener createOrientationEventListener() { return new OrientationEventListener(getContext()) { @Override From b8decaf11db53d7e664f6ec41132546a45b5f688 Mon Sep 17 00:00:00 2001 From: jesswrd Date: Fri, 25 Sep 2026 22:40:36 +0000 Subject: [PATCH 2/3] [camera_android_camerax] Update CHANGELOG and version --- packages/camera/camera_android_camerax/CHANGELOG.md | 4 ++++ packages/camera/camera_android_camerax/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/camera/camera_android_camerax/CHANGELOG.md b/packages/camera/camera_android_camerax/CHANGELOG.md index 9e8fa13ac644..0b327dcff2c7 100644 --- a/packages/camera/camera_android_camerax/CHANGELOG.md +++ b/packages/camera/camera_android_camerax/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.7.5+1 + +* Fixes a misplaced Javadoc comment that fails the example app build on JDK 23+. + ## 0.7.5 * Adds support for custom video output path in video recording. diff --git a/packages/camera/camera_android_camerax/pubspec.yaml b/packages/camera/camera_android_camerax/pubspec.yaml index 14355426e186..e44581040423 100644 --- a/packages/camera/camera_android_camerax/pubspec.yaml +++ b/packages/camera/camera_android_camerax/pubspec.yaml @@ -2,7 +2,7 @@ name: camera_android_camerax description: Android implementation of the camera plugin using the CameraX library. repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 -version: 0.7.5 +version: 0.7.5+1 environment: sdk: ^3.12.0 From 772892428eb6c18e4e4ef02c765ac9f968c07c3a Mon Sep 17 00:00:00 2001 From: Jessie Wong Date: Tue, 29 Sep 2026 17:07:00 +0000 Subject: [PATCH 3/3] Revert "[camera_android_camerax] Update CHANGELOG and version" This reverts commit b8decaf11db53d7e664f6ec41132546a45b5f688. --- packages/camera/camera_android_camerax/CHANGELOG.md | 4 ---- packages/camera/camera_android_camerax/pubspec.yaml | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/camera/camera_android_camerax/CHANGELOG.md b/packages/camera/camera_android_camerax/CHANGELOG.md index 0b327dcff2c7..9e8fa13ac644 100644 --- a/packages/camera/camera_android_camerax/CHANGELOG.md +++ b/packages/camera/camera_android_camerax/CHANGELOG.md @@ -1,7 +1,3 @@ -## 0.7.5+1 - -* Fixes a misplaced Javadoc comment that fails the example app build on JDK 23+. - ## 0.7.5 * Adds support for custom video output path in video recording. diff --git a/packages/camera/camera_android_camerax/pubspec.yaml b/packages/camera/camera_android_camerax/pubspec.yaml index e44581040423..14355426e186 100644 --- a/packages/camera/camera_android_camerax/pubspec.yaml +++ b/packages/camera/camera_android_camerax/pubspec.yaml @@ -2,7 +2,7 @@ name: camera_android_camerax description: Android implementation of the camera plugin using the CameraX library. repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 -version: 0.7.5+1 +version: 0.7.5 environment: sdk: ^3.12.0