Skip to content

Commit d4a0a74

Browse files
author
Jake Moss
committed
Flint does the normalisation itself, not sure why it didn't earlier
1 parent 8119b56 commit d4a0a74

5 files changed

Lines changed: 0 additions & 22 deletions

File tree

src/flint/flint_base/flint_base.pyx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -959,8 +959,6 @@ cdef class flint_mpoly(flint_elem):
959959
of the generators. Generators with names that are not found within the other
960960
context are mapped to 0. The mapping can be explicitly provided.
961961
962-
The resulting polynomial is also normalised.
963-
964962
>>> from flint import fmpz_mpoly_ctx
965963
>>> ctx = fmpz_mpoly_ctx.get(('x', 'y', 'a', 'b'))
966964
>>> ctx2 = fmpz_mpoly_ctx.get(('a', 'b'))

src/flint/types/fmpq_mpoly.pyx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ from flint.flintlib.functions.fmpq_mpoly cimport (
2020
fmpq_mpoly_add,
2121
fmpq_mpoly_add_fmpq,
2222
fmpq_mpoly_clear,
23-
fmpq_mpoly_combine_like_terms,
2423
fmpq_mpoly_compose_fmpq_mpoly,
2524
fmpq_mpoly_compose_fmpq_mpoly_gen,
2625
fmpq_mpoly_ctx_init,
@@ -42,7 +41,6 @@ from flint.flintlib.functions.fmpq_mpoly cimport (
4241
fmpq_mpoly_get_term_coeff_fmpq,
4342
fmpq_mpoly_get_term_exp_fmpz,
4443
fmpq_mpoly_integral,
45-
fmpq_mpoly_is_canonical,
4644
fmpq_mpoly_is_one,
4745
fmpq_mpoly_is_zero,
4846
fmpq_mpoly_length,
@@ -1134,10 +1132,6 @@ cdef class fmpq_mpoly(flint_mpoly):
11341132
(<fmpq_mpoly_ctx>ctx).val
11351133
)
11361134

1137-
if not fmpq_mpoly_is_canonical(res.val, res.ctx.val):
1138-
fmpq_mpoly_sort_terms(res.val, res.ctx.val)
1139-
fmpq_mpoly_combine_like_terms(res.val, res.ctx.val)
1140-
11411135
return res
11421136

11431137

src/flint/types/fmpz_mod_mpoly.pyx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ from flint.flintlib.functions.fmpz_mod_mpoly cimport (
1919
fmpz_mod_mpoly_add,
2020
fmpz_mod_mpoly_add_fmpz,
2121
fmpz_mod_mpoly_clear,
22-
fmpz_mod_mpoly_combine_like_terms,
2322
fmpz_mod_mpoly_compose_fmpz_mod_mpoly,
2423
fmpz_mod_mpoly_compose_fmpz_mod_mpoly_gen,
2524
fmpz_mod_mpoly_ctx_get_modulus,
@@ -43,7 +42,6 @@ from flint.flintlib.functions.fmpz_mod_mpoly cimport (
4342
fmpz_mod_mpoly_get_term_coeff_fmpz,
4443
fmpz_mod_mpoly_get_term_exp_fmpz,
4544
fmpz_mod_mpoly_inflate,
46-
fmpz_mod_mpoly_is_canonical,
4745
fmpz_mod_mpoly_is_one,
4846
fmpz_mod_mpoly_is_zero,
4947
fmpz_mod_mpoly_length,
@@ -1158,10 +1156,6 @@ cdef class fmpz_mod_mpoly(flint_mpoly):
11581156
(<fmpz_mod_mpoly_ctx>ctx).val
11591157
)
11601158

1161-
if not fmpz_mod_mpoly_is_canonical(res.val, res.ctx.val):
1162-
fmpz_mod_mpoly_sort_terms(res.val, res.ctx.val)
1163-
fmpz_mod_mpoly_combine_like_terms(res.val, res.ctx.val)
1164-
11651159
return res
11661160

11671161

src/flint/types/fmpz_mpoly.pyx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ from flint.flintlib.functions.fmpz_mpoly cimport (
2121
fmpz_mpoly_buchberger_naive,
2222
fmpz_mpoly_buchberger_naive_with_limits,
2323
fmpz_mpoly_clear,
24-
fmpz_mpoly_combine_like_terms,
2524
fmpz_mpoly_compose_fmpz_mpoly,
2625
fmpz_mpoly_compose_fmpz_mpoly_gen,
2726
fmpz_mpoly_ctx_init,
@@ -45,7 +44,6 @@ from flint.flintlib.functions.fmpz_mpoly cimport (
4544
fmpz_mpoly_get_term_exp_fmpz,
4645
fmpz_mpoly_inflate,
4746
fmpz_mpoly_integral,
48-
fmpz_mpoly_is_canonical,
4947
fmpz_mpoly_is_one,
5048
fmpz_mpoly_is_zero,
5149
fmpz_mpoly_length,

src/flint/types/nmod_mpoly.pyx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ from flint.flintlib.functions.nmod_mpoly cimport (
2121
nmod_mpoly_add,
2222
nmod_mpoly_add_ui,
2323
nmod_mpoly_clear,
24-
nmod_mpoly_combine_like_terms,
2524
nmod_mpoly_compose_nmod_mpoly_gen,
2625
nmod_mpoly_compose_nmod_mpoly,
2726
nmod_mpoly_ctx_init,
@@ -42,7 +41,6 @@ from flint.flintlib.functions.nmod_mpoly cimport (
4241
nmod_mpoly_get_str_pretty,
4342
nmod_mpoly_get_term_coeff_ui,
4443
nmod_mpoly_get_term_exp_fmpz,
45-
nmod_mpoly_is_canonical,
4644
nmod_mpoly_is_one,
4745
nmod_mpoly_is_zero,
4846
nmod_mpoly_length,
@@ -1129,10 +1127,6 @@ cdef class nmod_mpoly(flint_mpoly):
11291127
(<nmod_mpoly_ctx>ctx).val
11301128
)
11311129

1132-
if not nmod_mpoly_is_canonical(res.val, res.ctx.val):
1133-
nmod_mpoly_sort_terms(res.val, res.ctx.val)
1134-
nmod_mpoly_combine_like_terms(res.val, res.ctx.val)
1135-
11361130
return res
11371131

11381132

0 commit comments

Comments
 (0)