Skip to content

Commit 6e12555

Browse files
committed
Fix poor error reporting
1 parent 3ebd8ff commit 6e12555

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/flint/types/fmpq_mpoly.pyx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,16 +168,16 @@ cdef class fmpq_mpoly_ctx(flint_mpoly_context):
168168
res = create_fmpq_mpoly(self)
169169

170170
for i, (k, v) in enumerate(d.items()):
171-
v = any_as_fmpq(v)
172-
if v is NotImplemented:
171+
o = any_as_fmpq(v)
172+
if o is NotImplemented:
173173
raise TypeError(f"cannot coerce coefficient '{v}' to fmpq")
174174
elif len(k) != nvars:
175175
raise ValueError(f"expected {nvars} exponents, got {len(k)}")
176176

177177
exp_vec = fmpz_vec(k)
178178

179-
if v:
180-
fmpq_mpoly_push_term_fmpq_ffmpz(res.val, (<fmpq>v).val, exp_vec.val, self.val)
179+
if o:
180+
fmpq_mpoly_push_term_fmpq_ffmpz(res.val, (<fmpq>o).val, exp_vec.val, self.val)
181181

182182
fmpq_mpoly_sort_terms(res.val, self.val)
183183
fmpq_mpoly_reduce(res.val, self.val)

src/flint/types/fmpz_mpoly.pyx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,16 @@ cdef class fmpz_mpoly_ctx(flint_mpoly_context):
163163
res = create_fmpz_mpoly(self)
164164

165165
for i, (k, v) in enumerate(d.items()):
166-
v = any_as_fmpz(v)
167-
if v is NotImplemented:
166+
o = any_as_fmpz(v)
167+
if o is NotImplemented:
168168
raise TypeError(f"cannot coerce coefficient '{v}' to fmpz")
169169
elif len(k) != nvars:
170170
raise ValueError(f"expected {nvars} exponents, got {len(k)}")
171171

172172
exp_vec = fmpz_vec(k)
173173

174-
if v:
175-
fmpz_mpoly_push_term_fmpz_ffmpz(res.val, (<fmpz>v).val, exp_vec.val, self.val)
174+
if o:
175+
fmpz_mpoly_push_term_fmpz_ffmpz(res.val, (<fmpz>o).val, exp_vec.val, self.val)
176176

177177
fmpz_mpoly_sort_terms(res.val, self.val)
178178
return res

0 commit comments

Comments
 (0)