From f941fca6d4466d064b9fcf28d6c5449ec0d7703e Mon Sep 17 00:00:00 2001 From: Nicolas <20311743+nickscamara@users.noreply.github.com> Date: Fri, 2 Oct 2026 11:42:43 -0700 Subject: [PATCH] fix: make --objective optional for alexandria feedback 1.25.1 made --objective a required option, so feedback from agents using skill copies without it failed before sending, and the recommended --silent & pattern hid the error. The API already accepts feedback without an objective. Bump to 1.25.3. Co-authored-by: Cursor --- README.md | 2 +- package.json | 2 +- src/__tests__/alexandria-beta.test.ts | 12 +++++++++--- src/commands/alexandria-feedback.ts | 2 +- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index fdc500af80..7536ef7c69 100644 --- a/README.md +++ b/README.md @@ -1052,4 +1052,4 @@ firecrawl alexandria feedback --rating partial \ --rationale "Found summaries but could not retrieve attachments" --json ``` -`--objective` is the underlying goal of the session: what you or your user were ultimately trying to accomplish, beyond the single website. No job ID is required. Alexandria session feedback has no job-age deadline and does not refund credits. Optional `--provider-feedback` and `--capability-feedback` accept JSON arrays; see `firecrawl alexandria feedback --help` for their fields and issue codes. Capability issue codes are `new_capability_request` (requires `requestedFunctionality`), `missing_capability` (the provider exists but lacks this capability), `insufficient_functionality`, `incorrect_result`, `execution_error`, and `other`. Existing `feedback` and `search-feedback` commands retain their job-specific behavior. Endpoint feedback opt-out environment variables also apply to this command. +The optional `--objective` is the underlying goal of the session: what you or your user were ultimately trying to accomplish, beyond the single website. No job ID is required. Alexandria session feedback has no job-age deadline and does not refund credits. Optional `--provider-feedback` and `--capability-feedback` accept JSON arrays; see `firecrawl alexandria feedback --help` for their fields and issue codes. Capability issue codes are `new_capability_request` (requires `requestedFunctionality`), `missing_capability` (the provider exists but lacks this capability), `insufficient_functionality`, `incorrect_result`, `execution_error`, and `other`. Existing `feedback` and `search-feedback` commands retain their job-specific behavior. Endpoint feedback opt-out environment variables also apply to this command. diff --git a/package.json b/package.json index 5884aa87b2..2bbb644b37 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "firecrawl-cli", - "version": "1.25.2", + "version": "1.25.3", "publishConfig": { "tag": "latest" }, diff --git a/src/__tests__/alexandria-beta.test.ts b/src/__tests__/alexandria-beta.test.ts index 5ee27d7057..bc0d7142ce 100644 --- a/src/__tests__/alexandria-beta.test.ts +++ b/src/__tests__/alexandria-beta.test.ts @@ -1567,14 +1567,20 @@ const sessionFeedbackArgs = [ 'Missing documents', ]; -it('requires a non-blank objective before sending feedback', async () => { +it('sends session feedback without an objective', async () => { + response = { success: true, feedbackId: 'feedback-1', creditsRefunded: 0 }; const index = sessionFeedbackArgs.indexOf('--objective'); const withoutObjective = sessionFeedbackArgs.filter( (_, i) => i !== index && i !== index + 1 ); - expect((await cli(withoutObjective)).code).not.toBe(0); + expect((await cli(withoutObjective)).code).toBe(0); + expect(requests).toHaveLength(1); + expect(requests[0].body).not.toHaveProperty('objective'); +}); + +it('rejects a blank objective before sending feedback', async () => { const blank = [...sessionFeedbackArgs]; - blank[index + 1] = ' '; + blank[sessionFeedbackArgs.indexOf('--objective') + 1] = ' '; expect((await cli(blank)).code).not.toBe(0); expect(requests).toHaveLength(0); }); diff --git a/src/commands/alexandria-feedback.ts b/src/commands/alexandria-feedback.ts index 005c0e1007..ed3b1309c3 100644 --- a/src/commands/alexandria-feedback.ts +++ b/src/commands/alexandria-feedback.ts @@ -108,7 +108,7 @@ export function createAlexandriaFeedbackCommand(): Command { 'What you needed from the website', detail ) - .requiredOption( + .option( '--objective ', 'The underlying goal: what you or your user were ultimately trying to accomplish', detail