Skip to content

Commit 557e18e

Browse files
authored
fix(test): remove a deprecated flag from tests (FB-50) (#491)
`enable_create_table_v2` has been the default for a long time and no longer exists, drop it. Also fix the CI: pin an earlier `setuptools` & fix linter issue
1 parent 036fd29 commit 557e18e

3 files changed

Lines changed: 2 additions & 2 deletions

File tree

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ repos:
3939
rev: v0.4.0
4040
hooks:
4141
- id: black_nbconvert
42+
additional_dependencies: ["setuptools>=69,<82"] # 82+ removes pkg_resources
4243

4344
- repo: https://github.com/PyCQA/flake8
4445
rev: "4.0.1"

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ install_requires =
3636
pydantic[dotenv]>=1.8.2,<3.0.0
3737
python-dateutil>=2.8.2
3838
readerwriterlock>=1.0.9
39-
sqlparse @ git+https://github.com/lorenzhs/sqlparse.git@8d379386c1c3e103ee67ef6582ea1b7c2296aa5b
39+
sqlparse@git+https://github.com/lorenzhs/sqlparse.git@8d379386c1c3e103ee67ef6582ea1b7c2296aa5b
4040
trio>=0.22.0
4141
truststore>=0.10;python_version>="3.10"
4242
python_requires = >=3.9

tests/integration/dbapi/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ def select_geography_response() -> List[ColType]:
217217
def setup_struct_query() -> str:
218218
return """
219219
SET advanced_mode=1;
220-
SET enable_create_table_v2=true;
221220
SET enable_struct_syntax=true;
222221
SET prevent_create_on_information_schema=true;
223222
DROP TABLE IF EXISTS test_struct;

0 commit comments

Comments
 (0)