diff --git a/.eslintrc.js b/.eslintrc.js index ecc336961d9..fc9c3e76b41 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -14,6 +14,7 @@ module.exports = { rules: { "jsdoc/newline-after-description": "off", "jsdoc/require-jsdoc": ["warn", { publicOnly: true }], + "no-constant-condition": ["error", { checkLoops: false }], // Allow intentional `while (true)` and `do ... while (true)` loops. "no-restricted-globals": ["error", "name", "length"], "prefer-arrow-callback": "error", "prettier/prettier": "error", @@ -67,8 +68,6 @@ module.exports = { "@typescript-eslint/prefer-regexp-exec": "warn", // TODO(bkendall): remove, allow to error. "@typescript-eslint/restrict-plus-operands": "warn", // TODO(bkendall): remove, allow to error. "@typescript-eslint/restrict-template-expressions": "warn", // TODO(bkendall): remove, allow to error. - "no-constant-condition": "warn", // TODO(bkendall): remove, allow to error. - "no-fallthrough": "warn", // TODO(bkendall): remove, allow to error. }, }, { diff --git a/src/deploy/functions/containerCleaner.ts b/src/deploy/functions/containerCleaner.ts index 8834d07e2eb..3c274309c66 100644 --- a/src/deploy/functions/containerCleaner.ts +++ b/src/deploy/functions/containerCleaner.ts @@ -20,7 +20,6 @@ async function retry(func: () => Promise): Promise { const INITIAL_BACKOFF = 100; const TIMEOUT_MS = 10_000; let retry = 0; - // eslint-disable-next-line no-constant-condition while (true) { try { const timeout = new Promise((resolve, reject) => { diff --git a/src/deploy/functions/runtimes/node/versioning.ts b/src/deploy/functions/runtimes/node/versioning.ts index 80741b7636a..4445f42d66f 100644 --- a/src/deploy/functions/runtimes/node/versioning.ts +++ b/src/deploy/functions/runtimes/node/versioning.ts @@ -38,7 +38,6 @@ export const FUNCTIONS_SDK_VERSION_TOO_OLD_WARNING = */ export function findModuleVersion(name: string, resolvedPath: string): string | undefined { let searchPath = path.dirname(resolvedPath); - // eslint-disable-next-line no-constant-condition while (true) { if (searchPath === "/" || path.basename(searchPath) === "node_modules") { logger.debug( diff --git a/src/init/features/hosting/index.ts b/src/init/features/hosting/index.ts index 57f2dcad035..0defeaf23a5 100644 --- a/src/init/features/hosting/index.ts +++ b/src/init/features/hosting/index.ts @@ -40,8 +40,7 @@ export async function askQuestions(setup: Setup, config: Config, options: Option case "nuxt": case "nuxt2": case "express": - // "svelekit" should not be removed unless it's confirmed to not cause breakages. - case "svelekit": + case "svelekit": // "svelekit" should not be removed unless it's confirmed to not cause breakages. case "sveltekit": { logger.info(); const useAppHosting = await confirm({