Skip to content

fix(bigquery-firestore-export): helper crashes on real BigQuery TIME values #3068

Description

@cabljac

The kit's value conversion converts BigQuery temporal types via Timestamp.fromDate(new Date(value)), but a real TIME value (BigQuery.time("10:30:00").value === "10:30:00") makes new Date("10:30:00") invalid and Timestamp.fromDate throws Value for argument "seconds" is not a valid integer. - so a scheduled query whose results include a TIME column crashes the run. Probe-verified during review of #3056 (IzaakGough); that PR pins the throwing behavior with a test so this fix flips it deliberately. Decide the correct representation (probably keep the raw string, matching what the extension stored). Ledger: #2974.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions