Skip to content

fix(firestore-send-email): anchor the SMTP_CONNECTION_URI validation regex (kit and legacy) #3067

Description

@cabljac

The SMTP_CONNECTION_URI validationRegex accepts trailing garbage after a valid prefix: its first alternative has no $ anchor, so e.g. smtp://host:25 trailing junk passes. Probe-verified; ...)$|^$ rejects the garbage forms. The bug is inherited: the legacy firestore-send-email/extension.yaml ships the identical unanchored regex (only the legacy test file carried an anchored copy that never shipped). Fix both the kit (kits/firestore-send-email/src/config.ts:171) and the legacy extension.yaml.

PR #3057 added a characterization test that pins the current unanchored acceptance - it is written to flip when this fix lands, so update it deliberately. Found by review on #3057 (IzaakGough). Ledger: #2974.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions