Skip to content

Commit e88b70b

Browse files
committed
Update TypeScript code example
1 parent 7d41f02 commit e88b70b

4 files changed

Lines changed: 27 additions & 30 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
1-
name: CI
1+
name: Node.js CI
22

3-
on: [push, pull_request]
3+
on:
4+
push:
5+
branches: '**'
6+
tags-ignore: '**'
7+
pull_request:
8+
branches: '**'
49

510
jobs:
611

712
build:
813

9-
env:
10-
TSESTREE_SINGLE_RUN: 'false'
11-
1214
name: Build
1315

1416
runs-on: ubuntu-latest

example/ColoredCircle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ console.log(ColoredCircle.isPrototypeOf(ColoredCircle)); // false
141141
console.log(Object.isPrototypeOf(ColoredCircle)); // false
142142
console.log(Function.prototype.isPrototypeOf(ColoredCircle)); // true
143143

144-
function getBaseNames(derivedClass: Function): string[]
144+
function getBaseNames(derivedClass: new () => unknown): string[]
145145
{
146146
return getPrototypeListOf(derivedClass).map(({ name }: { name: string; }): string => name);
147147
}

gulpfile.js

Lines changed: 18 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -130,21 +130,21 @@ task
130130
'functions': 'only-multiline',
131131
},
132132
],
133-
'no-unused-vars':
134-
[
135-
'error',
136-
{
137-
args: 'none',
138-
caughtErrors: 'all',
139-
ignoreRestSiblings: true,
140-
vars: 'local',
141-
varsIgnorePattern: '^(?:Green|WhiteUnit)Circle$',
142-
},
143-
],
144133
'@stylistic/quotes': ['error', 'double'],
145134
};
146-
const { 'no-unused-vars': noUnusedVars, ...TS_EXAMPLE_RULES } = JS_EXAMPLE_RULES;
147-
TS_EXAMPLE_RULES['@typescript-eslint/no-unused-vars'] = noUnusedVars;
135+
const TS_EXAMPLE_RULES = { ...JS_EXAMPLE_RULES };
136+
JS_EXAMPLE_RULES['no-unused-vars'] =
137+
TS_EXAMPLE_RULES['@typescript-eslint/no-unused-vars'] =
138+
[
139+
'error',
140+
{
141+
args: 'none',
142+
caughtErrors: 'all',
143+
ignoreRestSiblings: true,
144+
vars: 'local',
145+
varsIgnorePattern: '^(?:Green|WhiteUnit)Circle$',
146+
},
147+
];
148148
const overrideConfig =
149149
await createConfig
150150
(
@@ -164,13 +164,9 @@ task
164164
jsVersion: 2022,
165165
},
166166
{
167-
files: ['**/*.ts', '**/*.tstest'],
168-
tsVersion: '4.7.0',
169-
languageOptions:
170-
{
171-
parserOptions:
172-
{ extraFileExtensions: ['.tstest'], project: 'tsconfig.json' },
173-
},
167+
files: ['**/*.ts', '**/*.tstest'],
168+
tsVersion: '4.7.0',
169+
languageOptions: { parserOptions: { extraFileExtensions: ['.tstest'] } },
174170
},
175171
{
176172
files: ['example/**/*.js'],
@@ -183,15 +179,14 @@ task
183179
rules: TS_EXAMPLE_RULES,
184180
},
185181
{
186-
files: ['lib/**/*.d.ts'],
187-
rules: { '@stylistic/max-len': 'off' },
182+
files: ['lib/**/*.d.ts'],
183+
rules: { '@stylistic/max-len': 'off' },
188184
},
189185
{
190186
files: ['**/*.tstest'],
191187
processor: tsTestProcessor,
192188
rules:
193189
{
194-
'@stylistic/spaced-comment': 'off',
195190
'@typescript-eslint/no-extraneous-class': 'off',
196191
'@typescript-eslint/no-misused-new': 'off',
197192
'@typescript-eslint/no-unused-vars': 'off',

test/spec/ts-defs/210.tstest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class B
1515

1616
void
1717
(
18-
(C: typeof A | typeof B): Function =>
18+
(C: typeof A | typeof B): (new () => unknown) =>
1919
class extends classes(C)
2020
{ }
2121
);

0 commit comments

Comments
 (0)