Upgrade Flow to 0.337.0 (#5432)

Summary:
Pull Request resolved: #5432

Upgrade Flow to 0.337.0 across Metro, React Native, and Relay. Flow 0.337 no longer special-cases `invariant`, so give `invariant` an `asserts` signature in the Metro and Relay Flow configs, matching React Native. Add targeted suppressions for the remaining new Flow 0.337 errors.

X-link: react/react-native#59326

X-link: react/metro#2086

[changelog](https://github.com/facebook/flow/blob/main/Changelog.md)

Changelog: [Internal]

Reviewed By: SamChou19815

Differential Revision: D126755886

Author: panagosg7

.flowconfig

@@ -4,6 +4,7 @@ compiler/**
 **/*/node_modules/**
 packages/relay-e2e-test/**
 **/node_modules/resolve/test/resolver/malformed_package_json/package.json
+**/node_modules/invariant/**
 
 [options]
 builtin_lib=core-only
@@ -13,6 +14,7 @@ module.system=haste
 module.system.haste.paths.excludes=.*/__tests__/.*
 module.system.haste.paths.excludes=.*/__mocks__/.*
 module.system.haste.paths.includes=<PROJECT_ROOT>/node_modules/fbjs/lib/.*
+module.system.haste.paths.excludes=<PROJECT_ROOT>/node_modules/fbjs/lib/invariant.*
 
 munge_underscores=true
 ; https://fburl.com/code/h2jnts20 - to match internval value
@@ -32,4 +34,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.336.0
+^0.337.0

flow-typed/npm/invariant_v2.x.x.js

@@ -0,0 +1,23 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @format
+ */
+
+declare module 'invariant' {
+  declare module.exports: (
+    condition: unknown,
+    format?: string,
+    ...args: Array<unknown>
+  ) => asserts condition;
+}
+
+declare module 'invariant/invariant' {
+  import typeof Invariant from 'invariant';
+
+  declare module.exports: Invariant;
+}

package.json

@@ -64,7 +64,7 @@
     "eslint-plugin-relay": "1.8.3",
     "eslint-plugin-relay-internal": "link:./packages/eslint-plugin-relay-internal",
     "fbjs": "^3.0.2",
-    "flow-bin": "^0.336.0",
+    "flow-bin": "^0.337.0",
     "flow-eslint": "0.336.0",
     "flow-parser": "0.336.0",
     "graphql": "15.3.0",

packages/relay-runtime/store/__tests__/RelayModernEnvironment-ExecuteWithUndeclaredUnusedArgument-test.js

@@ -138,6 +138,7 @@ describe('query with undeclared, unused fragment argument', () => {
       (snapshot.data as $FlowFixMe).node,
     );
     invariant(fragmentSelector != null, 'Expected a singular selector.');
+    // $FlowFixMe[incompatible-type] Flow 0.337
     const fragmentSnapshot = environment.lookup(fragmentSelector);
     expect(fragmentSnapshot.isMissingData).toBe(false);
     expect(fragmentSnapshot.data).toEqual({
@@ -157,6 +158,7 @@ describe('query with undeclared, unused fragment argument', () => {
       fragmentSnapshot.data as $FlowFixMe,
     );
     invariant(innerSelector != null, 'Expected a singular selector.');
+    // $FlowFixMe[incompatible-type] Flow 0.337
     const innerSnapshot = environment.lookup(innerSelector);
     expect(innerSnapshot.isMissingData).toBe(false);
     expect(innerSnapshot.data).toEqual({

yarn.lock

@@ -3699,10 +3699,10 @@ flatted@^3.1.0:
   resolved "https://registry.yarnpkg.com/flatted/-/flatted-3.2.6.tgz#022e9218c637f9f3fc9c35ab9c9193f05add60b2"
   integrity sha512-0sQoMh9s0BYsm+12Huy/rkKxVu4R1+r96YX5cG44rHV0pQ6iC3Q+mkoMFaGWObMFYQxCVT+ssG1ksneA2MI9KQ==
 
-flow-bin@^0.336.0:
-  version "0.336.0"
-  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.336.0.tgz#ac946f9cdf134b83ab4f7a98a0de34324f6b94f4"
-  integrity sha512-I5sPg/GISpXH4W14eGWgiIsrDKY0uvvvXjlEDOI2t0pguEwbMgpnaYzMMMBoHZcYYtNJIF/0eGsbPnN7uP2zOQ==
+flow-bin@^0.337.0:
+  version "0.337.0"
+  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.337.0.tgz#419252403924033308160351e95f723bcf42597c"
+  integrity sha512-rpr+WvY30RdXPNHbioErMM8tLKUOKJ8/neXPpsDYRBp9z7WDkl4bpTBUMZiqh9ozfdcDWEACBTXwIl94h/ZA0A==
 
 flow-eslint@0.336.0:
   version "0.336.0"