diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fcd73438c8..c6b4933675 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -276,6 +276,10 @@ jobs: build-dart: runs-on: ubuntu-latest timeout-minutes: 45 + # Without id-token, setup-dart skips the pub.dev token, so packages are + # fetched anonymously. + permissions: + contents: read steps: - uses: actions/checkout@v7.0.1 @@ -286,11 +290,6 @@ jobs: - name: Setup Dart SDK uses: dart-lang/setup-dart@v1 - # setup-dart registers a pub.dev token, which pub then sends on dependency - # fetches too. This job only consumes packages, so drop it and stay anonymous. - - name: Use pub.dev anonymously - run: dart pub token remove https://pub.dev - - name: Fable Tests - Dart run: ./build.sh test dart diff --git a/src/Fable.Transforms/Python/Prelude.fs b/src/Fable.Transforms/Python/Prelude.fs index d14f71f8a6..133c90ed69 100644 --- a/src/Fable.Transforms/Python/Prelude.fs +++ b/src/Fable.Transforms/Python/Prelude.fs @@ -173,7 +173,7 @@ module Naming = let reflectionSuffix = "_reflection" - let mutable uniqueIndex = 0 + let mutable private uniqueIndex = 0 let getUniqueIndex () = let idx = uniqueIndex diff --git a/src/fable-standalone/src/Worker/Worker.fs b/src/fable-standalone/src/Worker/Worker.fs index 56451a9d8c..1097937b16 100644 --- a/src/fable-standalone/src/Worker/Worker.fs +++ b/src/fable-standalone/src/Worker/Worker.fs @@ -285,7 +285,7 @@ let private compileFiles fable fsharpNames fsharpCodes (filesToEmit: string[]) l ) () - let mutable errors = parseResults.Errors + let errors = ResizeArray parseResults.Errors let mutable fableTransformTime = 0. let compiledCode = ResizeArray() @@ -293,8 +293,8 @@ let private compileFiles fable fsharpNames fsharpCodes (filesToEmit: string[]) l for fileName in filesToEmit do let! code, fableErrors, transformTime = emitFile fable parseResults fileName language fableOptions - compiledCode.Add(code) - errors <- Array.append errors fableErrors + compiledCode.Add code + errors.AddRange fableErrors fableTransformTime <- fableTransformTime + transformTime let stats: CompileStats = @@ -304,7 +304,7 @@ let private compileFiles fable fsharpNames fsharpCodes (filesToEmit: string[]) l Fable_transform = fableTransformTime } - return (compiledCode.ToArray(), errors, stats) + return (compiledCode.ToArray(), errors.ToArray(), stats) } let private describeError (er: exn) =