Skip to content

Commit a1c2f87

Browse files
committed
cleanup api
1 parent c26c090 commit a1c2f87

3 files changed

Lines changed: 4 additions & 30 deletions

File tree

pkg/sequencers/solo/README.md

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -51,31 +51,6 @@ flowchart TD
5151
H --> I["Return valid txs"]
5252
```
5353

54-
## Usage
55-
56-
```go
57-
seq := solo.NewSoloSequencer(
58-
logger,
59-
cfg,
60-
[]byte("chain-id"),
61-
1000, // maxQueueSize (0 = unlimited)
62-
genesis,
63-
executor,
64-
)
65-
66-
// Submit transactions from the mempool
67-
seq.SubmitBatchTxs(ctx, coresequencer.SubmitBatchTxsRequest{
68-
Id: []byte("chain-id"),
69-
Batch: &coresequencer.Batch{Transactions: txs},
70-
})
71-
72-
// Produce the next block
73-
resp, err := seq.GetNextBatch(ctx, coresequencer.GetNextBatchRequest{
74-
Id: []byte("chain-id"),
75-
MaxBytes: 500_000,
76-
})
77-
```
78-
7954
## Comparison with Other Sequencers
8055

8156
| Aspect | Solo | Single | Based |

pkg/sequencers/solo/sequencer.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212

1313
"github.com/evstack/ev-node/core/execution"
1414
coresequencer "github.com/evstack/ev-node/core/sequencer"
15-
"github.com/evstack/ev-node/pkg/config"
1615
)
1716

1817
var ErrInvalidID = errors.New("invalid chain id")
@@ -35,7 +34,6 @@ type SoloSequencer struct {
3534

3635
func NewSoloSequencer(
3736
logger zerolog.Logger,
38-
cfg config.Config,
3937
id []byte,
4038
executor execution.Executor,
4139
) *SoloSequencer {
@@ -128,6 +126,10 @@ func (s *SoloSequencer) GetNextBatch(ctx context.Context, req coresequencer.GetN
128126
}
129127

130128
func (s *SoloSequencer) VerifyBatch(ctx context.Context, req coresequencer.VerifyBatchRequest) (*coresequencer.VerifyBatchResponse, error) {
129+
if !s.isValid(req.Id) {
130+
return nil, ErrInvalidID
131+
}
132+
131133
return &coresequencer.VerifyBatchResponse{Status: true}, nil
132134
}
133135

pkg/sequencers/solo/sequencer_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212

1313
"github.com/evstack/ev-node/core/execution"
1414
coresequencer "github.com/evstack/ev-node/core/sequencer"
15-
"github.com/evstack/ev-node/pkg/config"
1615
"github.com/evstack/ev-node/test/mocks"
1716
)
1817

@@ -42,7 +41,6 @@ func createDefaultMockExecutor(t *testing.T) *mocks.MockExecutor {
4241
func newTestSequencer(t *testing.T) *SoloSequencer {
4342
return NewSoloSequencer(
4443
zerolog.Nop(),
45-
config.DefaultConfig(),
4644
[]byte("test"),
4745
createDefaultMockExecutor(t),
4846
)
@@ -152,7 +150,6 @@ func TestSoloSequencer_GetNextBatch_PostponedTxsRequeued(t *testing.T) {
152150

153151
seq := NewSoloSequencer(
154152
zerolog.Nop(),
155-
config.DefaultConfig(),
156153
[]byte("test"),
157154
mockExec,
158155
)

0 commit comments

Comments
 (0)