unit tests + lint

Author: julienrbrt

block/internal/submitting/da_submitter_mocks_test.go

@@ -45,12 +45,15 @@ func TestSubmitToDA_MempoolRetry_IncreasesGasAndSucceeds(t *testing.T) {
 
 	// First attempt returns a mempool-related error (mapped to StatusNotIncludedInBlock)
 	// Expect gasPrice=1.0
+
 	ns := "ns"
+	nsBz := coreda.NamespaceFromString(ns).Bytes()
+
 	opts := []byte("opts")
 	// capture gas prices used
 	var usedGas []float64
 	mockDA.
-		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), ns, opts).
+		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), nsBz, opts).
 		Run(func(args mock.Arguments) {
 			usedGas = append(usedGas, args.Get(2).(float64))
 		}).
@@ -60,7 +63,7 @@ func TestSubmitToDA_MempoolRetry_IncreasesGasAndSucceeds(t *testing.T) {
 	// Second attempt should use doubled gas price = 2.0 and succeed for all items
 	ids := [][]byte{[]byte("id1"), []byte("id2"), []byte("id3")}
 	mockDA.
-		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), ns, opts).
+		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), nsBz, opts).
 		Run(func(args mock.Arguments) {
 			usedGas = append(usedGas, args.Get(2).(float64))
 		}).
@@ -100,20 +103,22 @@ func TestSubmitToDA_UnknownError_RetriesSameGasThenSucceeds(t *testing.T) {
 	mockDA.On("GasMultiplier", mock.Anything).Return(3.0, nil).Once()
 
 	ns := "ns"
+	nsBz := coreda.NamespaceFromString(ns).Bytes()
+
 	opts := []byte("opts")
 	var usedGas []float64
 
 	// First attempt: unknown failure -> reasonFailure, gas unchanged for next attempt
 	mockDA.
-		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), ns, opts).
+		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), nsBz, opts).
 		Run(func(args mock.Arguments) { usedGas = append(usedGas, args.Get(2).(float64)) }).
 		Return(nil, errors.New("boom")).
 		Once()
 
 	// Second attempt: same gas, success
 	ids := [][]byte{[]byte("id1")}
 	mockDA.
-		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), ns, opts).
+		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), nsBz, opts).
 		Run(func(args mock.Arguments) { usedGas = append(usedGas, args.Get(2).(float64)) }).
 		Return(ids, nil).
 		Once()
@@ -148,13 +153,15 @@ func TestSubmitToDA_TooBig_HalvesBatch(t *testing.T) {
 	mockDA.On("GasMultiplier", mock.Anything).Return(2.0, nil).Once()
 
 	ns := "ns"
+	nsBz := coreda.NamespaceFromString(ns).Bytes()
+
 	opts := []byte("opts")
 	// record sizes of batches sent to DA
 	var batchSizes []int
 
 	// First attempt: too big -> should halve and retry
 	mockDA.
-		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.Anything, ns, opts).
+		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.Anything, nsBz, opts).
 		Run(func(args mock.Arguments) {
 			blobs := args.Get(1).([][]byte)
 			batchSizes = append(batchSizes, len(blobs))
@@ -165,7 +172,7 @@ func TestSubmitToDA_TooBig_HalvesBatch(t *testing.T) {
 	// Second attempt: expect half the size, succeed
 	ids := [][]byte{[]byte("id1"), []byte("id2")}
 	mockDA.
-		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.Anything, ns, opts).
+		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.Anything, nsBz, opts).
 		Run(func(args mock.Arguments) {
 			blobs := args.Get(1).([][]byte)
 			batchSizes = append(batchSizes, len(blobs))
@@ -203,20 +210,22 @@ func TestSubmitToDA_SentinelNoGas_PreservesGasAcrossRetries(t *testing.T) {
 	mockDA.On("GasMultiplier", mock.Anything).Return(10.0, nil).Once()
 
 	ns := "ns"
+	nsBz := coreda.NamespaceFromString(ns).Bytes()
+
 	opts := []byte("opts")
 	var usedGas []float64
 
 	// First attempt: mempool-ish error
 	mockDA.
-		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), ns, opts).
+		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), nsBz, opts).
 		Run(func(args mock.Arguments) { usedGas = append(usedGas, args.Get(2).(float64)) }).
 		Return(nil, coreda.ErrTxAlreadyInMempool).
 		Once()
 
 	// Second attempt: should use same sentinel gas (-1), succeed
 	ids := [][]byte{[]byte("id1")}
 	mockDA.
-		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), ns, opts).
+		On("SubmitWithOptions", mock.Anything, mock.Anything, mock.AnythingOfType("float64"), nsBz, opts).
 		Run(func(args mock.Arguments) { usedGas = append(usedGas, args.Get(2).(float64)) }).
 		Return(ids, nil).
 		Once()
@@ -250,17 +259,19 @@ func TestSubmitToDA_PartialSuccess_AdvancesWindow(t *testing.T) {
 	mockDA.On("GasMultiplier", mock.Anything).Return(2.0, nil).Once()
 
 	ns := "ns"
+	nsBz := coreda.NamespaceFromString(ns).Bytes()
+
 	opts := []byte("opts")
 	// track how many items postSubmit sees across attempts
 	var totalSubmitted int
 
 	// First attempt: success for first 2 of 3
 	firstIDs := [][]byte{[]byte("id1"), []byte("id2")}
-	mockDA.On("SubmitWithOptions", mock.Anything, mock.Anything, mock.Anything, ns, opts).Return(firstIDs, nil).Once()
+	mockDA.On("SubmitWithOptions", mock.Anything, mock.Anything, mock.Anything, nsBz, opts).Return(firstIDs, nil).Once()
 
 	// Second attempt: success for remaining 1
 	secondIDs := [][]byte{[]byte("id3")}
-	mockDA.On("SubmitWithOptions", mock.Anything, mock.Anything, mock.Anything, ns, opts).Return(secondIDs, nil).Once()
+	mockDA.On("SubmitWithOptions", mock.Anything, mock.Anything, mock.Anything, nsBz, opts).Return(secondIDs, nil).Once()
 
 	s := newTestSubmitter(mockDA, func(c *config.Config) { c.DA.GasPrice = 1.0 })
 

types/da_test.go

@@ -10,7 +10,6 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
 
-	"github.com/evstack/ev-node/core/da"
 	coreda "github.com/evstack/ev-node/core/da"
 	"github.com/evstack/ev-node/test/mocks"
 	"github.com/evstack/ev-node/types"
@@ -119,7 +118,7 @@ func TestSubmitWithHelpers(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			mockDA := mocks.NewMockDA(t)
 			namespace := "test-namespace"
-			encodedNamespace := da.NamespaceFromString(namespace)
+			encodedNamespace := coreda.NamespaceFromString(namespace)
 
 			mockDA.On("SubmitWithOptions", mock.Anything, tc.data, tc.gasPrice, encodedNamespace.Bytes(), tc.options).Return(tc.submitIDs, tc.submitErr)