Commit ebd3769
committed
Explicitly initialize gpsState.hwVersion to 0 in gpsInit()
Addresses Qodo code review suggestion to prevent sending uninitialized
memory over MSP_GPSSTATISTICS.
While global variables are zero-initialized in C, explicit initialization
is better practice:
- Makes intent clear in code
- Works for all GPS providers (UBLOX, MSP, FAKE)
- Future-proof if gpsState becomes non-global
- Documents that 0 means UNKNOWN
u-blox driver also initializes to UBX_HW_VERSION_UNKNOWN (0) during
configuration, but this ensures all code paths are safe.1 parent dda5ffd commit ebd3769
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
454 | 457 | | |
455 | 458 | | |
456 | 459 | | |
| |||
0 commit comments